Deprecate rake task rcov options #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Any reason not to merge? |
| @@ -69,19 +69,34 @@ def warning=(true_or_false) | |||
| # | |||
| # default: | |||
| # false | |||
| attr_accessor :rcov | |||
| attr_reader :rcov | |||
There was a problem hiding this comment.
Is it worth adding deprecation warnings to the attr readers as well?
There was a problem hiding this comment.
I didn't think so, but have done so anyway
Otherwise, users get deprecation warnings due to RSpec's usage of the deprecated methods.
myronmarston
added a commit
that referenced
this pull request
Jul 14, 2013
Deprecate rake task rcov options
|
I had to rebase it and fix it up a bit after merging other branches. Also, I implemented the call site fix we talked about. |
| RSpec.configuration.reporter.deprecation( | ||
| { | ||
| :deprecated => deprecated, | ||
| :call_site => caller(0)[2] | ||
| :call_site => call_site |
There was a problem hiding this comment.
We should pick this across for all our deprecation specs
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…cov_integration Deprecate rake task rcov options --- This commit was imported from rspec/rspec-core@013a04c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The follow up to #965, this deprecates the options we will shortly be removing.