Include a binstubs check before running CI script #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return $success | ||
| } | ||
|
|
||
| check_binstubs |
There was a problem hiding this comment.
Why are you calling this here? The check below in run_build makes sense but here it seems odd.
|
👍 Great idea! LGTM apart from the comment above. |
Newer RSpec contributors may not have setup binstubs. When running `script/run_build` locally it errors in confusing ways. Often at this point they are unsure how to properly get the binstubs onto the system. This includes a very simplistic check for the non-optional binstubs. It aggregates the missing binstubs and the associated gems, then provides the user helpful options on how to get the binstubs. While talking with the users it was decided that this is a kinder approach than simply forcing the creating of the binstubs. Better to inform the user then forcefully inject executables into their system.
cupakromer
force-pushed
the
check-binstubs-on-build
branch
from
5ac0cf8
to
d7c76ac
Compare
cupakromer
added a commit
that referenced
this pull request
Aug 1, 2015
Include a binstubs check before running CI script
|
Looks like this breaks our build :(. |
|
Looks like rspec-support needs a custom function for this. I'll look into it tomorrow. |
|
I see why...rspec-support doesn't use cucumber. The check for rspec-dev/travis/script/functions.sh Line 31 in 5098f79 |
|
NVM this needs a similar check: if [ -d features ]; then |
|
Updated in #25. Updated the other PRs and will wait for green properly 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer RSpec contributors may not have setup binstubs. When running
script/run_buildlocally it errors in confusing ways. Often at thispoint they are unsure how to properly get the binstubs onto the system.
This includes a very simplistic check for the non-optional binstubs. It
aggregates the missing binstubs and the associated gems, then provides
the user helpful options on how to get the binstubs.
While talking with the users it was decided that this is a kinder
approach than simply forcing the creating of the binstubs. Better to
inform the user then forcefully inject executables into their system.