Fix Dir#exists? deprecation warning.

rspec · Jan 7, 2023 · a85d0a6 · a85d0a6
1 parent 3d3045b
commit a85d0a6
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/Changelog.md b/Changelog.md
@@ -1,6 +1,10 @@
 ### Development
 [Full Changelog](http://github.com/rspec/rspec-expectations/compare/v3.12.1...3-12-maintenance)
 
+Bug Fixes:
+
+* Fix `exist` matcher warning when used with `Dir`. (Steve Dierker, #1398)
+
 ### 3.12.1 / 2022-12-16
 [Full Changelog](http://github.com/rspec/rspec-expectations/compare/v3.12.0...v3.12.1)
 

diff --git a/lib/rspec/matchers/built_in/exist.rb b/lib/rspec/matchers/built_in/exist.rb
@@ -81,7 +81,7 @@ def predicates
           end
 
           def deprecated(predicate, actual)
-            predicate == :exists? && (File == actual || FileTest == actual)
+            predicate == :exists? && (File == actual || FileTest == actual || Dir == actual)
           end
         end
       end

diff --git a/spec/rspec/matchers/built_in/exist_spec.rb b/spec/rspec/matchers/built_in/exist_spec.rb
@@ -131,6 +131,14 @@ def send
           expect(FileTest).to exist __FILE__
         end
       end
+
+      if RUBY_VERSION > "1.9"
+        context 'Dir has deprecated exists?' do
+          it 'will not call exists? triggering the warning' do
+            expect(Dir).to exist Dir.pwd
+          end
+        end
+      end
     end
   end