Better diff coloring

[alexcoplan]

Change configuration in RSpec::Matchers to use the same color config method as RSpec::Core (if core is available). Also made the diff coloring code more readable and succinct.

[travisbot]

This pull request passes (merged 248004e into d427bac).

[myronmarston]

Honestly, I find this to be less readable and succinct than what you had before. I don't have a preference for color(text, red) over red(text) as an API (both seem equally fine to me), but using a hash and define_method adds extra indirection over what you had before. If you want the separate methods for each color, I'd prefer:

def red
  color(text, 31)
end

def green
  color(text, 32)
end

def blue
  color(text, 34)
end

I know on 1.8 that methods defined with define_method are slower when called than methods defined with def. Not sure about 1.9 (I haven't benchmarked it), but I expect it's still slower. So that's another reason to prefer def over define_method for this case.

[travisbot]

This pull request passes (merged 7cdd88b into d427bac).

[alexcoplan]

@myronmarston OK, have changed it to multiple method defs.

[myronmarston]

Thanks, I just merged it.