Quick spec clean up #593
Merged
Quick spec clean up #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW, I like re-opening the modules and nesting them like this so that we can reference rspec constants without needing the full qualification. It wasn't needed here, though, and I'm fine with this if you prefer it, though...but if I was writing this from scratch I'd probably still write it up the way that it was before :). |
|
FWIW I personally don't like that style, but I accept it's used in RSpec, but as the constant was unreferenced here I nixed it. I mostly wanted to remove the trailing ws, you know me ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a quick spec clean up.