Address MRI 2.2 warnings (possible reference to past scope). #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From ruby/ruby@f5f6218. It causes 280 warnings in our spec suite :(. The fix is to change the names of variables and/or `let` definitions so they do not clash. See https://bugs.ruby-lang.org/issues/10661 for more discussion.
|
This is ready for a review and hopefully a merge. The build in question is here: https://travis-ci.org/rspec/rspec-expectations/jobs/45315736 Note that it's failing due to an rspec-core issue that is addressed by rspec/rspec-core#1818. |
|
(/cc @rspec/rspec) |
|
Merging so I can open new PRs that build against 2.2. |
myronmarston
added a commit
that referenced
this pull request
Dec 29, 2014
Address MRI 2.2 warnings (possible reference to past scope).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From ruby/ruby@f5f6218.
It causes 280 warnings in our spec suite :(. The fix is to change the names of
variables and/or
letdefinitions so they do not clash.See https://bugs.ruby-lang.org/issues/10661 for more discussion.