Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address MRI 2.2 warnings (possible reference to past scope). #703

Merged
merged 1 commit into from Dec 29, 2014

Conversation

@myronmarston
Copy link
Member

commented Dec 29, 2014

From ruby/ruby@f5f6218.
It causes 280 warnings in our spec suite :(. The fix is to change the names of
variables and/or let definitions so they do not clash.

See https://bugs.ruby-lang.org/issues/10661 for more discussion.

Address MRI 2.2 warnings (possible reference to past scope).
From ruby/ruby@f5f6218.
It causes 280 warnings in our spec suite :(. The fix is to change the names of
variables and/or `let` definitions so they do not clash.

See https://bugs.ruby-lang.org/issues/10661 for more discussion.
@myronmarston

This comment has been minimized.

Copy link
Member Author

commented Dec 29, 2014

This is ready for a review and hopefully a merge. The build in question is here:

https://travis-ci.org/rspec/rspec-expectations/jobs/45315736

Note that it's failing due to an rspec-core issue that is addressed by rspec/rspec-core#1818.

@myronmarston

This comment has been minimized.

Copy link
Member Author

commented Dec 29, 2014

(/cc @rspec/rspec)

@myronmarston

This comment has been minimized.

Copy link
Member Author

commented Dec 29, 2014

Merging so I can open new PRs that build against 2.2.

myronmarston added a commit that referenced this pull request Dec 29, 2014

Merge pull request #703 from rspec/address-2.2-issues
Address MRI 2.2 warnings (possible reference to past scope).

@myronmarston myronmarston merged commit f5fd2c7 into master Dec 29, 2014

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci The Travis CI build passed
Details

@myronmarston myronmarston deleted the address-2.2-issues branch Dec 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.