Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prep for extra options on failure_notifier #793

Closed
wants to merge 1 commit into from
Closed

Prep for extra options on failure_notifier #793

wants to merge 1 commit into from

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented May 27, 2015

We wrap the RAISE_METHOD in a similarly captured proc so that adding options to the failure_notifier won't break it, similarly we prep aggregate_failures for receiving options.

@JonRowe
Copy link
Member Author

JonRowe commented May 29, 2015

This isn't needed if we take @myronmarston's approach with rspec/rspec-support#210

@JonRowe JonRowe closed this May 29, 2015
@JonRowe JonRowe deleted the prep_for_failure_notifier_by_id branch May 29, 2015 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@JonRowe