Support block snippet extraction with aliased matchers #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... so that the matcher can know what name it was called. The interface is not smart but we cannot pass matcher name to the constructor with the current matcher protocol.
myronmarston
approved these changes
May 4, 2017
| if defined?(@matcher_name) | ||
| @matcher_name | ||
| else | ||
| self.class.matcher_name |
There was a problem hiding this comment.
Why does this fall back to the class method (and is there a matcher_name class method even defined?).
There was a problem hiding this comment.
Because #matcher_name= is set only when aliased (i.e. @matcher_name is nil when using matchers with their original name)..
The class method is defined here.
yujinakayama
deleted the
support-block-snippet-extraction-with-aliased-matchers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #987.
The interface is not smart but we cannot pass matcher name to the constructor with the current matcher protocol.