Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with rspec 3's change to describe :symbol behavior #12

Closed
myronmarston opened this issue Mar 17, 2014 · 4 comments
Closed

Deal with rspec 3's change to describe :symbol behavior #12

myronmarston opened this issue Mar 17, 2014 · 4 comments
Assignees

Comments

@myronmarston
Copy link
Member

See rspec/rspec-core#1240, rspec/rspec-core#1403 and rspec/rspec-core#1405.

You'll probably have to apply a change similar to what was done to its in 1405.

/cc @palfvin

@palfvin
Copy link
Contributor

palfvin commented Mar 29, 2014

Sorry for the delay on this. Should be able to get to it tomorrow.

@palfvin
Copy link
Contributor

palfvin commented Apr 13, 2014

@myronmarston Assuming that its should continue to treat a symbol argument as it does a string argument, I can see that I have to coerce the former into the latter before passing it to describe in the implementation, but I'm not understanding how this relates to rspec/rspec-core#1405. Or perhaps I'm not parsing your "You'll probably have to apply a change similar to what was done to its in 1405." comment correctly.

@myronmarston
Copy link
Member Author

I'm not understanding how this relates to rspec/rspec-core#1405. Or perhaps I'm not parsing your "You'll probably have to apply a change similar to what was done to its in 1405." comment correctly.

I was specifically referring to the change to its that was part of that PR:

https://github.com/rspec/rspec-core/pull/1405/files#diff-bfb3a47487070f8b14dd153557ac2d51L491

@palfvin
Copy link
Contributor

palfvin commented Apr 13, 2014

Of course. I didn't see the modification in the PR changes when I reviewed them initially, but should have checked the its source. Would have saved us both some time ...

palfvin added a commit that referenced this issue Apr 13, 2014
…warning

Improves #12 and #15 based on Myron's feedback.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants