Creating rspec-its gem for rspec-core issue #1083

[palfvin]

Submitted for code review.

[myronmarston]

What's this file for?

[palfvin]

I was keeping track of some things I wanted to bring up with you, but I ended up answering them all myself prior to the last commit. I'll get rid of it and use github mechanisms going forward.

[JonRowe]

We should also run the rspec repo's with --order rand and --warnings

[palfvin]

Don't mean to press, guys, but wanted to make sure you'd seen #1 (comment) If you don't know what to do about it off hand, let me know and I'll dig into it.

[palfvin]

I've been getitng the following warning when I run the rspec examples:

/Users/palfvin/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/openssl/ssl.rb:101: warning: assigned but unused variable - id

and I'm also getting three warnings about rspec-core redefining constants that are previously defined in rspec-expectations. You can see them at https://travis-ci.org/palfvin/rspec-its/jobs/11993819

Are those anything I need to worry about?

[JonRowe]

The openssl warnings are, afaik, something we can't do anything about. I've looked at them before. The redefining constants warnings might be fixable, but they're not anything to worry about.

[JonRowe]

Still an incorrect line ending here ;)

[palfvin]

Thanks for persisting. ;-) Turns out I didn't realize glob didn't handle . files. Then I realized I didn't really understand how to match an empty string. Anyway, next commit will be "clean" in this respect.

[JonRowe]

Looks good to me, I left a few more notes but they're mostly about formatting.

[myronmarston]

Looks good...merge away whenever you want to :).

[palfvin]

Sorry for displaying yet more naivete, but what are the next steps for publishing this to rubygems? I see that there's a version of rspec_collection-matchers out there, but it's got a lot of oddities, including:

• You (Myron) as creator, not the gem author
• A documentation link at the top that's broken
• No set of source, documentation, etc. links on the bottom like rspec-core

And do you want me to go ahead and submit the pull request for the 3.0 extraction or do you want to get the rubygems things squared aware first?

[JonRowe]

@palfvin that will be myron just place holdering the gem, you can start on the PR for extraction and Myron will sort the gem deployment out with you at some point.

Note I like to check that this sort of thing works in the following way, create some specs in an empty gemset that follow this pattern. It's ok to do this manually.

| 2.14           | Works            |
| 2.99           | Work but warn    |
| 2.99 + gem     | Work, no warning |
| 3.x            | Fail             |
| 3.x + gem      | Work             |