Merge pull request #387 from yannlugrin/drb_with_exclusion_tags

Allow tag exclusion filtering when using drb
rspec · May 26, 2011 · 4ef0c29 · 4ef0c29
2 parents 3cab6c2 + b6a71b7
commit 4ef0c29
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/lib/rspec/core/configuration_options.rb b/lib/rspec/core/configuration_options.rb
@@ -39,6 +39,11 @@ def drb_argv
             argv << "--tag" << k.to_s
           end
         end
+        if options[:exclusion_filter]
+          options[:exclusion_filter].each_pair do |k, v|
+            argv << "--tag" << "~#{k.to_s}"
+          end
+        end
         if options[:formatters]
           options[:formatters].each do |pair|
             argv << "--format" << pair[0]

diff --git a/spec/rspec/core/configuration_options_spec.rb b/spec/rspec/core/configuration_options_spec.rb
@@ -224,16 +224,27 @@ def parse_options(*args)
     end
 
     context "with tags" do
-      it "includes the tags" do
+      it "includes the inclusion tags" do
         coo = config_options_object("--tag", "tag")
         coo.drb_argv.should eq(["--tag", "tag"])
       end
 
-      it "leaves tags intact" do
+      it "leaves inclusion tags intact" do
         coo = config_options_object("--tag", "tag")
         coo.drb_argv
         coo.options[:filter].should eq( {:tag=>true} )
       end
+
+      it "includes the exclusion tags" do
+        coo = config_options_object("--tag", "~tag")
+        coo.drb_argv.should eq(["--tag", "~tag"])
+      end
+
+      it "leaves exclusion tags intact" do
+        coo = config_options_object("--tag", "~tag")
+        coo.drb_argv
+        coo.options[:exclusion_filter].should eq( {:tag=>true} )
+      end
     end
 
     context "with formatters" do