Output deprecation warning when at_least(0) is sent #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @michihuber. I need to go back and read #133 to fully understand the discussion before merging this, but it looks generally good. |
|
Let me know if you also want to deprecate #any_number_of_times. |
|
I think this looks fine now. We've fixed the problems with the specs and I'm generally in favour of this. @myronmarston what do you think? |
fables-tales
pushed a commit
that referenced
this pull request
May 12, 2013
Output deprecation warning when at_least(0) is sent
fables-tales
pushed a commit
that referenced
this pull request
May 12, 2013
Signed-off-by: Sam Phippen <samphippen@googlemail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #133