Verify the ordering of spies. #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -86,7 +86,7 @@ def generate_failure_message | |||
|
|
|||
| def expected_messages_received? | |||
| mock_proxy.replay_received_message_on @expectation, &@block | |||
| @expectation.expected_messages_received? | |||
| @expectation.expected_messages_received? && @expectation.expected_ordering_received? | |||
| end | |||
There was a problem hiding this comment.
I think it's a little confusing for this method to be called expected_messages_received? when it does more than that now. Maybe it should be renamed to something like expected_messages_received_in_specified_order? or something?
|
Updated the wording too. |
|
Refactored the loop, refactored the object message tuple to use a value objects. Ready for re-review. |
| when Module then @module = module_or_name | ||
| when String then @name = module_or_name | ||
| when Module then @module = module_or_name; @name = nil | ||
| when String then @name = module_or_name; @module = nil |
There was a problem hiding this comment.
This file has been refactored in master and I suspect this won't merge now.
|
LGTM. Merge away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register invokation order of calls and use it to verify that spies
have been called in order correctly.
Fixes #430.