Marshal monkey-patch deprecation #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| unless ::RSpec::Mocks.configuration.marshal_patched? | ||
| RSpec.warn_deprecation(<<-EOS.gsub(/^\s+\|/, '')) | ||
| |Using Marshal.dump on stubbed objects relies on a monkey-patch | ||
| |that is being made opt-in in RSpec 3. To enable it: |
There was a problem hiding this comment.
"To enable it" should perhaps be "To enable it (and silence this warning)"
There was a problem hiding this comment.
or 'To silence this warning please explicitly enable it:'
|
LGTM. If we change the API in #620 to be an attribute like I suggested, it'll need to change here as well, of course, but otherwise merge away. |
|
comments addressed. |
|
LGTM. If you do decide to add a reader to 3.0, it'd be good to use the same name here (rather than the shortened |
xaviershay
added a commit
that referenced
this pull request
Mar 8, 2014
Marshal monkey-patch deprecation
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…-deprecation Marshal monkey-patch deprecation --- This commit was imported from rspec/rspec-mocks@678ba90.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #620