-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails 7.1 upgrade: using deprecated preview_path= #2703
Comments
Thanks for the in-depth report, Do you want to send a PR to fix this, @juanxcerv ? |
This can be reproduced with this clean ruby 7.1.1 project: https://github.com/dannyy83/debug_action_mailer_deprication You can see the deprication warning being raised by visiting the |
@JonRowe Thank you for fixing!! Would you be able to cut a new release 🙏🏼 |
Hit this during an upgrade to Ruby 3.3.5 / Rails 7.2.x. Running on master resolved that exception around |
Thats funny we don't have a master branch, prehaps you meant |
My apologies. Main. I was still experiencing this in rspec-rails 7.0. May have been a cache issue, but had to switch to the github call in the gemfile. |
What Ruby, Rails and RSpec versions are you using?
Ruby version: 3.2.2
Rails version: 7.1.1
RSpec version: 3.12
Observed behaviour
Inside of
rspec-rails-6.0.3/lib/rspec-rails.rb
it's using the deprecated methodpreview_path
:which ultimately gets set as a config for
action_mailer
:and causes the following message to trigger:
Expected behaviour
No deprecation warning
Thanks!
The text was updated successfully, but these errors were encountered: