-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix preview paths #2706
Fix preview paths #2706
Conversation
/cc @alexevanczuk |
if ENV['CUSTOM_PREVIEW_PATH'] | ||
config.action_mailer.preview_path = ENV['CUSTOM_PREVIEW_PATH'] | ||
if Rails::VERSION::STRING.start_with?('7.1') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JonRowe Won't this fail with Rails 7.2+? Would it be better to do a >=
comparison?
Hey @JonRowe let me know if this is something that you're still working on or if I can help out! |
53537ba
to
1d32341
Compare
1d32341
to
dbaa79f
Compare
Can you please make a release that includes this? 🙏 The current release (6.0.3) does not include this, and is therefore not compatible with Rails 7.1 (when using |
A related question: While waiting for a release, is there an easy way to use the edge/unreleased version? I tried
|
@TylerRick I'm in the same situation as you, and this works for me:
|
Thanks, @dannyy83, and glad to hear I'm not alone. I landed on something similar. Too bad you have to override all of those dependencies, but I guess it makes sense, due to the version constraint on "= 3.13.0.pre)". |
Fix released in 6.1.0 for Rails 7.1 support. Side note, if you depend on the |
On Rails 7.1 they changed the preview path setup for mailers to be multiple rather than singular, this PR handles that change conditionally in the railtie and fixes our test setup around the mailers. Fixes #2703.