New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added feature specs for have_enqueued_job matcher #1486
Added feature specs for have_enqueued_job matcher #1486
Conversation
I'm trying to figure out how to conditionally skip tests when AJ is not available, so I added cucumber step https://github.com/rspec/rspec-rails/pull/1486/files#diff-e6a0765839735d337aa3101a10bc43bbR6 but I don't know how to implement it, as https://github.com/rspec/rspec-rails/pull/1486/files#diff-922aab2260697e2bbe72d3df4147da81R7 is evaluated in context of |
@@ -2,3 +2,7 @@ | |||
step %q{the output should contain "0 failures"} | |||
step %q{the exit status should be 0} | |||
end | |||
|
|||
Given /active job integrated/ do | |||
pending "ActiveJob is not available" if false # Implement checking if ActiveJob is available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you require the relevant part of rspec-rails you'll be able to do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JonRowe Now tests are passing
Thanks for documenting this! I spoke briefly about this matcher in a talk I gave at the Cleveland Ruby Brigade meetup last Thursday, so it's great to get a cuke around this so more people can know about it :) |
Added feature specs for have_enqueued_job matcher
Any ETA on next |
Releasing 3.4.0 this week has been under discussion - I can't promise a specific date, but soon! |
Follow up to #1464 and #1480