#1108 use recognize_path and values_match? to handle composable matchers in RouteToMatcher #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chers in RouteToMatcher
|
hi @jtxyz sorry I'm only just getting to this. Could you take a look at the failing tests on CI and fix them up? Then we can go ahead with review. Thanks ✨ |
|
Can you please rebase and add a test that would fail without this patch @jtxyz ? |
pirj
reviewed
Jan 15, 2020
| @recognized_path = @scope.routes.recognize_path( | ||
| path, { | ||
| method: verb_to_path_map.keys.first, | ||
| extras: Rack::Utils::parse_nested_query(query) |
| end | ||
|
|
||
| def failure_message | ||
| rescued_exception.message | ||
| if rescued_exception | ||
| rescued_exception.message |
There was a problem hiding this comment.
Is it possible to use safe navigation here?
|
Closing as stale. Feel free to reopen if you have time on your hands to wrap it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt at tackling #1108 (no tests yet)