Load spec_helper before Rails #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that things in spec_helper, especially coverage tools, have a chance to load before the Rails code loads
kjg
force-pushed
the
load_spec_helper_first
branch
from
021a01f
to
213029c
Compare
|
@kjg I'm not entirely sure about this. Can you explain your use case or need a little more? |
|
@samphippen Simplecov, for example, says that it must be loaded before any of the application code in order to properly track code coverage. If you have your Simplecov init in your spec_helper (which makes sense because you want coverage on all files, not just files that need rails_helper), you have Simplecov init at the top of spec_helper, but rails_helper is loading your Rails files before spec_helper and therefor before Simplecov. Does that make sense? |
|
@samphippen I would recommend this change as well to be honest, given |
|
TIL hitting merge doesn't also post your comment :) |
sebjacobs
pushed a commit
to futurelearn/rspec-rails
that referenced
this pull request
Mar 15, 2019
so that things in spec_helper, especially coverage tools, have a chance to load before the Rails code loads
sebjacobs
pushed a commit
to futurelearn/rspec-rails
that referenced
this pull request
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that things in spec_helper, especially coverage tools,
have a chance to load before the Rails code loads