Upgrade rubocop, motivated by CVE. #1939
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know WTF is going on with the build but I don't think it's green on master. |
|
I tried to rebase you PR (master...benoittgt:upgrade-rubocop), test are ok on ruby 2.4.1p111 but Rubocop shows 399 offenses 😢 |
|
Sadly I think we can close this PR. Rubocop will be updated in rspec-rails 4. https://github.com/rspec/rspec-rails/pull/2071/files#diff-8b7db4d5cc4b8f6dc8feb7030baa2478R59 And as I mention, there is too much offenses too fix a probably a big conflict with 4-0-dev. Sorry Xavier. |
|
Closing in favour of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defaulted most new things to off, though tried to keep performance and linters.
Note that
.rubocop_rspec_basedoesn't 100% match up withrspec-devbecause I was adding to it as we went along. Once these are all merged I'm planning to ensure they're all consistent.