-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Udpate nokogiri version #2032
Udpate nokogiri version #2032
Conversation
1ad0e17
to
a46e256
Compare
Seems like a good idea to me. 👍 The build failure on 2.4 is related to a missing DB table, not Nokogiri. A retry might help there. @BobbyMcWho would you kindly write a sentence or two in the PR description justifying this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, will happily merge when you've tidied up that extra space.
Gemfile
Outdated
@@ -59,10 +59,12 @@ gem 'rack-cache', '< 1.3.0' if RUBY_VERSION < '2.0.0' | |||
|
|||
if RUBY_VERSION < '1.9.2' | |||
gem 'nokogiri', '~> 1.5.0' | |||
elsif RUBY_VERSION < '1.9.3' | |||
elsif RUBY_VERSION < '1.9.3' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the extra space you've inserted here please.
56c009d
to
ed2f5e2
Compare
* Update nokogiri version
In response to various nokogiri CVEs, most recently sparklemotion/nokogiri#1786