Updates from rspec-dev (2019-12-18) #2239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
force-pushed
the
update-travis-build-scripts-2019-12-18-for-master
branch
from
95166db
to
e237e18
Compare
JonRowe
deleted the
update-travis-build-scripts-2019-12-18-for-master
branch
|
Closed because this needs tweaking to make it not conflict |
JonRowe
restored the
update-travis-build-scripts-2019-12-18-for-master
branch
JonRowe
force-pushed
the
update-travis-build-scripts-2019-12-18-for-master
branch
from
40f81bb
to
f3c6c49
Compare
Closed
JonRowe
force-pushed
the
update-travis-build-scripts-2019-12-18-for-master
branch
from
bf5d9ae
to
4f9100d
Compare
On Bundler 2.1.0 the loading of rubygems has been rewritten. It breaks our existing usage of command execution. The --disable=gem flag is problematic because we need to load rubygems in Bundler. It is not explicitly loaded in Bundle 2.1.0 Related: - rubygems/bundler#7487
JonRowe
force-pushed
the
update-travis-build-scripts-2019-12-18-for-master
branch
from
26260e4
to
d530d40
Compare
|
@benoittgt @pirj I think this stands a good chance of going green (its late here so I'm off), its the bare minimum with @benoittgt's rubygems unset and @mvz's bundler patch for Aruba, plus ignoring 4.2.0 (because of bundler 1.x required and we're dropping support anyway) and ignoring a warning on jruby only. 🤞 |
JonRowe
force-pushed
the
update-travis-build-scripts-2019-12-18-for-master
branch
from
99bb19d
to
00aa976
Compare
mvz
reviewed
Dec 20, 2019
| in_current_directory do | ||
| super(exec_cmd, timeout) | ||
| with_unbundled_env do |
There was a problem hiding this comment.
I think this call to with_unbundled_env is not needed.
There was a problem hiding this comment.
Yep, #2244 did not need it.
|
I merged #2244 in preference as it does less. |
JonRowe
deleted the
update-travis-build-scripts-2019-12-18-for-master
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some updates, generated from rspec-dev's rake tasks.