-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update travis build scripts 2019 12 20 for master #2244
Merged
JonRowe
merged 6 commits into
master
from
update-travis-build-scripts-2019-12-20-for-master
Dec 20, 2019
Merged
Update travis build scripts 2019 12 20 for master #2244
JonRowe
merged 6 commits into
master
from
update-travis-build-scripts-2019-12-20-for-master
Dec 20, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
commented
Dec 20, 2019
@@ -42,21 +42,12 @@ else | |||
gem 'sqlite3', '~> 1.3.6', platforms: [:ruby] | |||
end | |||
|
|||
if RUBY_VERSION >= '2.4.0' | |||
gem 'json', '>= 2.0.2' | |||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically these made no difference for this build.
benoittgt
approved these changes
Dec 20, 2019
We have many open PR for the same thing (#2239). I am happy to merge this one. |
JonRowe
added a commit
that referenced
this pull request
Dec 28, 2019
…12-20-for-master Update travis build scripts 2019 12 20 for master
JonRowe
added a commit
that referenced
this pull request
Jan 12, 2020
…12-20-for-master Update travis build scripts 2019 12 20 for master
pirj
pushed a commit
that referenced
this pull request
Jun 29, 2020
…12-20-for-master Update travis build scripts 2019 12 20 for master
pirj
pushed a commit
that referenced
this pull request
Jul 20, 2020
…12-20-for-master Update travis build scripts 2019 12 20 for master
pirj
pushed a commit
that referenced
this pull request
Jul 21, 2020
…12-20-for-master Update travis build scripts 2019 12 20 for master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@benoittgt @pirj this seems to be the minimum required changes to get our build green so I'm proposing we use this...