Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update travis build scripts 2019 12 20 for master #2244

Merged
merged 6 commits into from
Dec 20, 2019

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Dec 20, 2019

@benoittgt @pirj this seems to be the minimum required changes to get our build green so I'm proposing we use this...

@@ -42,21 +42,12 @@ else
gem 'sqlite3', '~> 1.3.6', platforms: [:ruby]
end

if RUBY_VERSION >= '2.4.0'
gem 'json', '>= 2.0.2'
end
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically these made no difference for this build.

spec/sanity_check_spec.rb Show resolved Hide resolved
@benoittgt
Copy link
Member

We have many open PR for the same thing (#2239). I am happy to merge this one.

@JonRowe JonRowe merged commit 657a16f into master Dec 20, 2019
@JonRowe JonRowe deleted the update-travis-build-scripts-2019-12-20-for-master branch December 20, 2019 13:07
JonRowe added a commit that referenced this pull request Dec 28, 2019
…12-20-for-master

Update travis build scripts 2019 12 20 for master
JonRowe added a commit that referenced this pull request Jan 12, 2020
…12-20-for-master

Update travis build scripts 2019 12 20 for master
pirj pushed a commit that referenced this pull request Jun 29, 2020
…12-20-for-master

Update travis build scripts 2019 12 20 for master
pirj pushed a commit that referenced this pull request Jul 20, 2020
…12-20-for-master

Update travis build scripts 2019 12 20 for master
pirj pushed a commit that referenced this pull request Jul 21, 2020
…12-20-for-master

Update travis build scripts 2019 12 20 for master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants