Fix sanity check dep mvz #2241
Closed
Fix sanity check dep mvz #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid:
Failures:
1) Verify required rspec dependencies passes when libraries are required
Got 1 failure and 1 other error:
1.1) Failure/Error: expect(`bundle exec #{script} 2>&1`).to be_empty
expected `"WARNING: open-ended dependency on activesupport (>= 4.2) is not recommended\n if activesupport is ... 'railties', '~> 4.2'\nWARNING: See http://guides.rubygems.org/specification-reference/ for help\n".empty?` to return true, got false
On Bundler 2.1.0 the loading of rubygems has been rewritten. It breaks our existing usage of command execution. The --disable=gem flag is problematic because we need to load rubygems in Bundler. It is not explicitly loaded in Bundle 2.1.0 Related: - rubygems/bundler#7487
This reverts commit be5a2c5.
This reverts commit 39be63a.
This reverts commit d1f8e95.
Merged
benoittgt
added a commit
that referenced
this pull request
Jan 3, 2020
With new bundler update like 2.1.2 and 2.1.3 we saw issues on the CI after running `bundle exec cucumber`: ``` +/home/travis/.rvm/gems/ruby-2.6.3/gems/bundler-2.1.3/lib/bundler/runtime.rb:312:in `check_for_activated_spec!': You have already activated bundler 2.1.2, but your Gemfile requires bundler 2.1.3. Since bundler is a default gem, you can either remove your dependency on it or try updating to a newer version of bundler that supports bundler as a default gem. (Gem::LoadError) ``` Using the patch from mvz #2241 reduce the amount of error
benoittgt
added a commit
that referenced
this pull request
Jan 4, 2020
With new bundler update like 2.1.2 and 2.1.3 we saw issues on the CI after running `bundle exec cucumber`: ``` +/home/travis/.rvm/gems/ruby-2.6.3/gems/bundler-2.1.3/lib/bundler/runtime.rb:312:in `check_for_activated_spec!': You have already activated bundler 2.1.2, but your Gemfile requires bundler 2.1.3. Since bundler is a default gem, you can either remove your dependency on it or try updating to a newer version of bundler that supports bundler as a default gem. (Gem::LoadError) ``` Using the patch from mvz #2241 reduce the amount of error
JonRowe
pushed a commit
that referenced
this pull request
Jan 12, 2020
With new bundler update like 2.1.2 and 2.1.3 we saw issues on the CI after running `bundle exec cucumber`: ``` +/home/travis/.rvm/gems/ruby-2.6.3/gems/bundler-2.1.3/lib/bundler/runtime.rb:312:in `check_for_activated_spec!': You have already activated bundler 2.1.2, but your Gemfile requires bundler 2.1.3. Since bundler is a default gem, you can either remove your dependency on it or try updating to a newer version of bundler that supports bundler as a default gem. (Gem::LoadError) ``` Using the patch from mvz #2241 reduce the amount of error
JonRowe
pushed a commit
that referenced
this pull request
Jan 12, 2020
With new bundler update like 2.1.2 and 2.1.3 we saw issues on the CI after running `bundle exec cucumber`: ``` +/home/travis/.rvm/gems/ruby-2.6.3/gems/bundler-2.1.3/lib/bundler/runtime.rb:312:in `check_for_activated_spec!': You have already activated bundler 2.1.2, but your Gemfile requires bundler 2.1.3. Since bundler is a default gem, you can either remove your dependency on it or try updating to a newer version of bundler that supports bundler as a default gem. (Gem::LoadError) ``` Using the patch from mvz #2241 reduce the amount of error
pirj
pushed a commit
that referenced
this pull request
Jun 29, 2020
With new bundler update like 2.1.2 and 2.1.3 we saw issues on the CI after running `bundle exec cucumber`: ``` +/home/travis/.rvm/gems/ruby-2.6.3/gems/bundler-2.1.3/lib/bundler/runtime.rb:312:in `check_for_activated_spec!': You have already activated bundler 2.1.2, but your Gemfile requires bundler 2.1.3. Since bundler is a default gem, you can either remove your dependency on it or try updating to a newer version of bundler that supports bundler as a default gem. (Gem::LoadError) ``` Using the patch from mvz #2241 reduce the amount of error
pirj
pushed a commit
that referenced
this pull request
Jul 20, 2020
With new bundler update like 2.1.2 and 2.1.3 we saw issues on the CI after running `bundle exec cucumber`: ``` +/home/travis/.rvm/gems/ruby-2.6.3/gems/bundler-2.1.3/lib/bundler/runtime.rb:312:in `check_for_activated_spec!': You have already activated bundler 2.1.2, but your Gemfile requires bundler 2.1.3. Since bundler is a default gem, you can either remove your dependency on it or try updating to a newer version of bundler that supports bundler as a default gem. (Gem::LoadError) ``` Using the patch from mvz #2241 reduce the amount of error
pirj
pushed a commit
that referenced
this pull request
Jul 21, 2020
With new bundler update like 2.1.2 and 2.1.3 we saw issues on the CI after running `bundle exec cucumber`: ``` +/home/travis/.rvm/gems/ruby-2.6.3/gems/bundler-2.1.3/lib/bundler/runtime.rb:312:in `check_for_activated_spec!': You have already activated bundler 2.1.2, but your Gemfile requires bundler 2.1.3. Since bundler is a default gem, you can either remove your dependency on it or try updating to a newer version of bundler that supports bundler as a default gem. (Gem::LoadError) ``` Using the patch from mvz #2241 reduce the amount of error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying stuff to fix #2231 (comment)