Add extra spec for time offsets / frozen time #2346
Conversation
JonRowe
force-pushed
the
add-active-job-offset-example
branch
from
2cabe68
to
33188f6
Compare
| @@ -33,6 +33,8 @@ def self.find(_id) | |||
| end | |||
|
|
|||
| RSpec.describe "ActiveJob matchers", skip: !RSpec::Rails::FeatureCheck.has_active_job? do | |||
| include ActiveSupport::Testing::TimeHelpers if defined?(ActiveSupport::Testing::TimeHelpers) | |||
There was a problem hiding this comment.
When it might not be available exactly?
There was a problem hiding this comment.
I mean it's clear that freeze_time isn't part of it, but TimeHelpers should be always available, and it's not necessary to check if they are defined (I hope we're requiring them somewhere).
There was a problem hiding this comment.
Oh ok, I was just checking freeze_time feel free to open a PR if you'd like to improve it, maybe backfill an implementation fir freeze_time if you have time?
There was a problem hiding this comment.
backfill an implementation for freeze_time
Noway! :D
If just for tests - it's kind of useless since we already run those specs against Rails that have it. For usage in tests - there's TimeCop (god forgive me) - wouldn't dare to write yet another one we'll have to support.
|
LGTM. I am looking for the sprockets bumping issue on the CI. |
Add extra spec for time offsets / frozen time
No description provided.