Prevent sprocket install failure when we are using Ruby below 2.5 #2347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
reviewed
May 25, 2020
| @@ -63,6 +63,10 @@ end | |||
|
|
|||
| gem "rubyzip", '~> 1.2' | |||
|
|
|||
| if RUBY_VERSION.to_f < 2.5 | |||
| gem 'sprockets', '~> 3.7.0' | |||
There was a problem hiding this comment.
Won't Bundler figure it out on its own? They do specify a version:
s.required_ruby_version = '>= 2.5.0'
shouldn't bundle take this into account and check out sprockets < 4.0 when it understands that 4+ won't work?
There was a problem hiding this comment.
This what I thought but the CI failed earlier for this PR #2346. But I am not able to find it again. It was on Ruby 2.4.
I will close it for now. We will see if it happen again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Randomly sprocket 4 can be installed on the CI on Ruby version below 2.5.
We should not have this behavior.
This change prevent this kind of random issue on the CI.
Related: