-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 3-9-maintenance CI failures #2360
Commits on Jul 27, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 02858cb - Browse repository at this point
Copy the full SHA 02858cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fcdae4 - Browse repository at this point
Copy the full SHA 4fcdae4View commit details -
Could not find gem 'puma' in https://github.com/rails/rails.git (at 5-2-stable@92fd1c2). The source does not contain any versions of 'puma'
Configuration menu - View commit details
-
Copy full SHA for c4ff60b - Browse repository at this point
Copy the full SHA c4ff60bView commit details -
Provide historical info to avoid confusion
In this example, we're making sure that `view` is available in global config hooks. `group.run` accepts a reporter, but it defaults to a NullReporter anyway.
Configuration menu - View commit details
-
Copy full SHA for c7b8a6c - Browse repository at this point
Copy the full SHA c7b8a6cView commit details -
Make sure we use compatible i18n for old Rubies
2.2 support has been dropped from 1.5.2 https://rubygems.org/gems/i18n/versions/1.5.2 https://rubygems.org/gems/i18n/versions/1.5.1
Configuration menu - View commit details
-
Copy full SHA for 6162f89 - Browse repository at this point
Copy the full SHA 6162f89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8075525 - Browse repository at this point
Copy the full SHA 8075525View commit details -
When installed from scratch on 2.2.10 with RubyGems 2.3.10 and Bundler 1.17.3, with RAILS_VERSION set to `5-2-stable`: childprocess-3.0.0 requires ruby version >= 2.3.0, which is incompatible with the current version, ruby 2.2.10p489 xpath-3.2.0 requires ruby version >= 2.3, which is incompatible with the current version, ruby 2.2.10p489 i18n-1.8.3 requires ruby version >= 2.3.0, which is incompatible with the current version, ruby 2.2.10p489 nio4r-2.5.2 requires ruby version >= 2.3, which is incompatible with the current version, ruby 2.2.10p489 rack-2.2.3 requires ruby version >= 2.3.0, which is incompatible with the current version, ruby 2.2.10p489 public_suffix-4.0.5 requires ruby version >= 2.3, which is incompatible with the current version, ruby 2.2.10p489 rubyzip-2.3.0 requires ruby version >= 2.4, which is incompatible with the current version, ruby 2.2.10p489 sprockets-4.0.2 requires ruby version >= 2.5.0, which is incompatible with the current version, ruby 2.2.10p489 We had sprockets capped, but only for `'~> x.x.x'`/`x.x.x` formats.
Configuration menu - View commit details
-
Copy full SHA for 088bce9 - Browse repository at this point
Copy the full SHA 088bce9View commit details -
Add error handling to bundler downgrade
`set -e` stops the script when a *simple command* fails. If the command is part of an `||`-expression, the script continues. It seems unessential that we fail to uninstall `bundler` from the global gemset, the build is green after all.
Configuration menu - View commit details
-
Copy full SHA for a53facb - Browse repository at this point
Copy the full SHA a53facbView commit details -
actionpack was resolved to 3.2.22.5, which depends on sprockets (~> 2.2.1)
Configuration menu - View commit details
-
Copy full SHA for a7dd9d6 - Browse repository at this point
Copy the full SHA a7dd9d6View commit details -
Warning: unrecognized cop BinaryOperatorParameterName found in /home/travis/build/rspec/rspec-rails/.rubocop_rspec_base.yml
Configuration menu - View commit details
-
Copy full SHA for a87877e - Browse repository at this point
Copy the full SHA a87877eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b1e7fe - Browse repository at this point
Copy the full SHA 2b1e7feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 102ba31 - Browse repository at this point
Copy the full SHA 102ba31View commit details -
Remove cops unknown to CI RuboCop version
RucoCop on CI is fixed at 0.23, and has outdated cop names. Even without those disabling, `rubocop lib` passes just fine.
Configuration menu - View commit details
-
Copy full SHA for f5ebf79 - Browse repository at this point
Copy the full SHA f5ebf79View commit details -
Fix install-time gem version incompatibilities
Gem::RuntimeRequirementNotMetError: public_suffix requires Ruby version >= 1.9.3. The current ruby version is 1.8. An error occurred while installing public_suffix (1.4.2), and Bundler cannot continue. Gem::RuntimeRequirementNotMetError: redcarpet requires Ruby version >= 1.9.2. The current ruby version is 1.8. An error occurred while installing redcarpet (3.1.1), and Bundler cannot continue. Gem::RuntimeRequirementNotMetError: rubyzip requires Ruby version >= 1.9.2. The current ruby version is 1.8. An error occurred while installing rubyzip (1.0.0), and Bundler cannot continue.
Configuration menu - View commit details
-
Copy full SHA for bed4459 - Browse repository at this point
Copy the full SHA bed4459View commit details -
Backport skipping of a spec due to Rails bug
Update to the latest released Rails 5.2.4.3 didn't help, it still has the bug. Backported from https://github.com/rspec/rspec-rails/blob/c0a8c22186a1232e3b1612c44bc88052ec56c945/spec/rspec/rails/example/view_example_group_spec.rb#L239
Configuration menu - View commit details
-
Copy full SHA for 89dd9ec - Browse repository at this point
Copy the full SHA 89dd9ecView commit details -
Test a stable version of Rails 5.2 with Ruby 2.2
For the reasons described in the comment
Configuration menu - View commit details
-
Copy full SHA for 6a8fd07 - Browse repository at this point
Copy the full SHA 6a8fd07View commit details -
bundle exec rails new ./tmp/example_app --no-rc --skip-javascript --skip-bootsnap --skip-sprockets --skip-git --skip-test-unit --skip-listen --skip-bundle --template=example_app_generator/generate_app.rb Gem::RuntimeRequirementNotMetError: spring requires Ruby version >= 2.4.0. The current ruby version is 2.3.0. An error occurred while installing spring (2.1.0), and Bundler cannot continue.
Configuration menu - View commit details
-
Copy full SHA for 0a3703e - Browse repository at this point
Copy the full SHA 0a3703eView commit details -
Cap Aruba and ffi to resolve version conflicts
ffi has strict Ruby constraints aruba: Bundler could not find compatible versions for gem "thor": In Gemfile: aruba (~> 0.14.11) was resolved to 0.14.12, which depends on thor (~> 0.19) rails (~> 3.1.12) was resolved to 3.1.12, which depends on railties (= 3.1.12) was resolved to 3.1.12, which depends on thor (~> 0.14.6)
Configuration menu - View commit details
-
Copy full SHA for 6e6a144 - Browse repository at this point
Copy the full SHA 6e6a144View commit details -
Use the previous aruba for older Rails
https://github.com/rspec/rspec-rails/pull/2140/files#diff-73c25cf975ccb4c89d8659202506c353L58 bumped aruba from 0.5.4 straight to 0.14.12. Using the version that used to work for older rails.
Configuration menu - View commit details
-
Copy full SHA for 5781ea1 - Browse repository at this point
Copy the full SHA 5781ea1View commit details -
Add 5-2-stable Ruby 2.2 build to allowed failures
There's a minor difference: Widget management User creates a new widget -1 example, 0 failures, 1 pending +1 example, 0 failures most probably caused by 5-2-stable vs 5.2.4.x spec generation difference.
Configuration menu - View commit details
-
Copy full SHA for a8dd5e1 - Browse repository at this point
Copy the full SHA a8dd5e1View commit details
Commits on Jul 28, 2020
-
Clarify why a specific version of Aruba is used
Co-authored-by: Jon Rowe <hello@jonrowe.co.uk>
Configuration menu - View commit details
-
Copy full SHA for 1dcff41 - Browse repository at this point
Copy the full SHA 1dcff41View commit details