Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be conservative on which Rails version is supported #2474

Closed
wants to merge 1 commit into from

Conversation

guigs
Copy link

@guigs guigs commented Mar 3, 2021

rspec-rails 3.9 can be installed with Rails 6.1, because it does not limit which rails version is supported, but it actually does not support Rails 6.1. It is not possible to add restriction on the next point release (let's say 3.9.2), because bundler will then install previous version (3.9.1) that does not have the dependency restriction.

Moving forward with rspec-rails 4.1, I think we should be more conservative on which Rails version is supported. If it happens that the next rails version (6.2 or 7.0) is still compatible, it will be easy to make a point release of rspec-rails 4.1.x with the upper bound dependency on Rails updated.

`rspec-rails` 3.9 can be installed with Rails 6.1, because it does not limit which rails version is supported, but it actually have issues with Rails 6.1. It is not possible to add restriction on the next point release (let's say 3.9.2), because bundler will then install previous version (3.9.1) that does not have the dependency restriction.

Moving forward with rspec-rails 4.1, I think we should be more conservative on which Rails version is supported. If it happens that the next rails version (6.2 or 7.0) is still compatible, it will be easy to make a point release of rspec-rails 4.1.x with the upper bound dependency on Rails updated.
@JonRowe
Copy link
Member

JonRowe commented Mar 3, 2021

The same problem applies here, as in #2473, any released version of a gem that doesn't have this constraint can be installed by bundler, a new major version could have this constraint added but there would still be no indication for the previous version that anything is wrong.

@guigs
Copy link
Author

guigs commented Mar 3, 2021

Yes, true, but if you have gem 'rspec-rails', '~> 4.1' in your Gemfile, it will work. I think at some point in future this will beneficial, so the sooner we add the better.

@JonRowe
Copy link
Member

JonRowe commented Mar 6, 2021

I'm sorry I don't want to merge this, if the top version is constrained what happens is Bundler picks an older even less compatible version. I would rather that the most recent version is installed in the case of incompatibility, so we get bug reports and can fix and release versions.

@JonRowe JonRowe closed this Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants