Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent using 3.9 with Rails 6.1 #2473

Closed
wants to merge 1 commit into from
Closed

Conversation

guigs
Copy link

@guigs guigs commented Mar 2, 2021

There's an issue with Rails 6.1 that caused error WrongScopeError, which was only fixed in rspec-rails 4.0 by #2215.

This should warn the user that rspec-rails need to be upgraded.

There's an issue with Rails 6.1 that caused error `WrongScopeError`, which was only fixed in rspec-rails 4.0 by rspec#2215.
@JonRowe JonRowe closed this Mar 2, 2021
@JonRowe
Copy link
Member

JonRowe commented Mar 2, 2021

Sorry thats not possible, bundler will just go further down the dependency chain.

@guigs
Copy link
Author

guigs commented Mar 3, 2021

What do you mean?

@JonRowe
Copy link
Member

JonRowe commented Mar 3, 2021

We can't alter existing released versions of gems, and when you have some versions of a gem, say 3.9.1 and 3.9.2 and only 3.9.2 restricts Rails to < 6.1 from bundlers point of view its ok to install 3.9.1 and Rails 6.1

So it is not possible to fix, you'll just get older versions of gems that don't have the restriction.

@guigs
Copy link
Author

guigs commented Mar 3, 2021

Aha, I see. Makes totally sense. Thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants