with_priority matcher for ActiveJob
#2759
Merged
+89
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
reviewed
Apr 18, 2024
| hello_job.set(priority: 2).perform_later | ||
| }.to have_enqueued_job.with_priority("2") | ||
| end | ||
|
|
There was a problem hiding this comment.
Can you please add a fee more cases? I can think of a failure case when we expect priority and it wasn’t set. Also when it was set, but doesn’t match the expectation. In both examples with checks if our failure message is reasonable.
I had another scenario on the tip of my tongue, but it keeps slipping. Can you think of other cases we should cover? You can use other similar qualifiers as a source of inspiration .
By the way, does this apply to mailers?
|
It also makes sense to add/extend scenario here Those changes will appear here https://rspec.info/features/6-1/rspec-rails/job-specs/job-spec/, and some prefer those docs to the rdoc ones. |
JonRowe
reviewed
Apr 20, 2024
| @@ -30,6 +31,11 @@ def on_queue(queue) | |||
| self | |||
| end | |||
|
|
|||
| def with_priority(priority) | |||
There was a problem hiding this comment.
Personally I would call this priority or at_priority to disambigute from with
|
ping @mbajur |
|
Thank you @mbajur ! |
|
Released in 7.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2757