Don't assume presence of ApplicationController for anonymous controllers. #924

Merged
merged 2 commits into from Feb 10, 2014

Conversation

Projects
None yet
4 participants
@JonRowe
Member

JonRowe commented Feb 6, 2014

Apparently some of our developers don't have a root ApplicationController so
let's check for it's presence and use ActionController::Base when it's not
around. Should fix #922.

@JonRowe

This comment has been minimized.

Show comment
Hide comment
@JonRowe

JonRowe Feb 6, 2014

Member
Member

JonRowe commented Feb 6, 2014

@alindeman

This comment has been minimized.

Show comment
Hide comment
@alindeman

alindeman Feb 10, 2014

Contributor

Sweet! Thanks for doing this. When Travis goes green, I'll merge.

Contributor

alindeman commented Feb 10, 2014

Sweet! Thanks for doing this. When Travis goes green, I'll merge.

@alindeman

This comment has been minimized.

Show comment
Hide comment
@alindeman

alindeman Feb 10, 2014

Contributor

Darn it! Fooled by def

Contributor

alindeman commented Feb 10, 2014

Darn it! Fooled by def

alindeman added a commit that referenced this pull request Feb 10, 2014

Merge pull request #924 from rspec/dont_assume_root_controller_is_app…
…lication_controller

Don't assume presence of ApplicationController for anonymous controllers.

@alindeman alindeman merged commit 2a44340 into master Feb 10, 2014

@alindeman alindeman deleted the dont_assume_root_controller_is_application_controller branch Feb 10, 2014

alindeman added a commit that referenced this pull request Feb 10, 2014

alindeman added a commit that referenced this pull request Feb 10, 2014

@billychan

This comment has been minimized.

Show comment
Hide comment
@billychan

billychan Feb 10, 2014

Contributor

That's nice!

Contributor

billychan commented Feb 10, 2014

That's nice!

@mhenrixon

This comment has been minimized.

Show comment
Hide comment
@mhenrixon

mhenrixon Feb 10, 2014

So nice of you to fix that! Thanks a bunch :)

So nice of you to fix that! Thanks a bunch :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment