Don't assume presence of ApplicationController for anonymous controllers. #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @alindeman |
|
Sweet! Thanks for doing this. When Travis goes green, I'll merge. |
|
Darn it! Fooled by |
alindeman
added a commit
that referenced
this pull request
Feb 10, 2014
…lication_controller Don't assume presence of ApplicationController for anonymous controllers.
alindeman
deleted the
dont_assume_root_controller_is_application_controller
branch
alindeman
added a commit
that referenced
this pull request
Feb 10, 2014
…lication_controller Fixes in #924 for 2.99
alindeman
added a commit
that referenced
this pull request
Feb 10, 2014
…lication_controller Fixes #924 for 2.14
|
That's nice! |
|
So nice of you to fix that! Thanks a bunch :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently some of our developers don't have a root
ApplicationControllersolet's check for it's presence and use
ActionController::Basewhen it's notaround. Should fix #922.