Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings with perl 5.21.2 #12

Closed
karenetheridge opened this issue Aug 1, 2014 · 2 comments
Closed

Warnings with perl 5.21.2 #12

karenetheridge opened this issue Aug 1, 2014 · 2 comments

Comments

@karenetheridge
Copy link
Contributor

Lots of these in the tests:

Redundant argument in sprintf at /Users/ether/.cpanm/work/1406914551.35459/Test-Moose-More-0.024/blib/lib/Test/Moose/More.pm line 94.

@rsrchboy
Copy link
Owner

Can you force a confess() there please, if this is still happening? (Carp::Always is friendly here)

@karenetheridge
Copy link
Contributor Author

: [ether@bourbon 1421624523.53187/Test-Moose-More-0.026]$; HARNESS_OPTIONS= prove -lr t
t/00-check-deps.t ................ ok    
t/00-compile.t ................... ok   
t/000-report-versions-tiny.t ..... # 

# Generated by Dist::Zilla::Plugin::ReportVersions::Tiny v1.10
# perl: 5.021006 (wanted 5.006) on darwin from /Users/ether/perl5/perlbrew/perls/21.6/bin/perl5.21.6
# 
# Class::MOP                                    => 2.1403     (want any version)
# Data::OptList                                 => 0.109      (want any version)
# ExtUtils::MakeMaker                           => 7.0507     (want any version)
# File::Spec                                    => 3.51       (want any version)
# IO::Handle                                    => 1.35       (want any version)
# IPC::Open3                                    => 1.18       (want any version)
# Moose                                         => 2.1403     (want any version)
# Moose::Autobox                                => 0.15       (want any version)
# Moose::Role                                   => 2.1403     (want any version)
# Moose::Util                                   => 2.1403     (want any version)
# Moose::Util::TypeConstraints                  => 2.1403     (want any version)
# Perl::Version                                 => 1.013      (want any version)
# Scalar::Util                                  => 1.41       (want any version)
# Sub::Exporter                                 => 0.987      (want any version)
# Syntax::Keyword::Junction                     => 0.003008   (want any version)
# TAP::SimpleOutput                             => 0.002      (want 0.002)  
# Test::Builder                                 => 1.301001097 (want any version)
# Test::Builder::Tester                         => 1.301001097 (want any version)
# Test::CheckDeps                               => 0.010      (want 0.010)  
# Test::Moose                                   => 2.1403     (want any version)
# Test::More                                    => 1.301001097 (want 0.94)   
# aliased                                       => 0.34       (want any version)
# constant                                      => 1.32       (want any version)
# namespace::autoclean                          => 0.24       (want any version)
# strict                                        => 1.08       (want any version)
# warnings                                      => 1.29       (want any version)
# 
# Thanks for using my code.  I hope it works for you.
# If not, please try and include this output in the bug report.
# That will help me reproduce the issue and solve your problem.
# 
t/000-report-versions-tiny.t ..... ok   
t/attribute/coerce.t ............. ok   
t/check_sugar.t .................. ok   
t/does_not_ok.t .................. 1/? Redundant argument in sprintf at /Users/ether/.cpanm/work/1421624523.53187/Test-Moose-More-0.026/lib/Test/Moose/More.pm line 107.
Redundant argument in sprintf at /Users/ether/.cpanm/work/1421624523.53187/Test-Moose-More-0.026/lib/Test/Moose/More.pm line 107.
Redundant argument in sprintf at /Users/ether/.cpanm/work/1421624523.53187/Test-Moose-More-0.026/lib/Test/Moose/More.pm line 107.
Redundant argument in sprintf at /Users/ether/.cpanm/work/1421624523.53187/Test-Moose-More-0.026/lib/Test/Moose/More.pm line 107.
Redundant argument in sprintf at /Users/ether/.cpanm/work/1421624523.53187/Test-Moose-More-0.026/lib/Test/Moose/More.pm line 107.
Redundant argument in sprintf at /Users/ether/.cpanm/work/1421624523.53187/Test-Moose-More-0.026/lib/Test/Moose/More.pm line 107.
t/does_not_ok.t .................. ok    
t/does_ok.t ...................... 1/? Redundant argument in sprintf at /Users/ether/.cpanm/work/1421624523.53187/Test-Moose-More-0.026/lib/Test/Moose/More.pm line 92.
Redundant argument in sprintf at /Users/ether/.cpanm/work/1421624523.53187/Test-Moose-More-0.026/lib/Test/Moose/More.pm line 92.
Redundant argument in sprintf at /Users/ether/.cpanm/work/1421624523.53187/Test-Moose-More-0.026/lib/Test/Moose/More.pm line 92.
Redundant argument in sprintf at /Users/ether/.cpanm/work/1421624523.53187/Test-Moose-More-0.026/lib/Test/Moose/More.pm line 92.
Redundant argument in sprintf at /Users/ether/.cpanm/work/1421624523.53187/Test-Moose-More-0.026/lib/Test/Moose/More.pm line 92.
Redundant argument in sprintf at /Users/ether/.cpanm/work/1421624523.53187/Test-Moose-More-0.026/lib/Test/Moose/More.pm line 92.
t/does_ok.t ...................... ok    
t/has_attribute_ok.t ............. ok    
t/has_method_ok.t ................ ok   
t/is_anon.t ...................... ok   
t/is_class.t ..................... ok   
t/is_not_anon.t .................. ok   
t/is_role.t ...................... ok   
t/meta_ok.t ...................... ok   
t/requires_method_ok.t ........... ok   
t/validate_attribute.t ........... ok   
t/validate_attribute/in_roles.t .. ok   
t/validate_class.t ............... ok   
t/validate_role.t ................ ok   
All tests successful.
Files=19, Tests=124,  6 wallclock secs ( 0.08 usr  0.04 sys +  5.05 cusr  0.34 csys =  5.51 CPU)
Result: PASS
: [ether@bourbon 1421624523.53187/Test-Moose-More-0.026]$; perl -Ilib -d:Confess t/does_not_ok.t 
# single role, default message - OK
ok 1 - TestClass is found to not do TestRole::Role correctly
ok 2 - TestRole is found to not do TestRole::Role correctly
# single role, custom message - OK
Redundant argument in sprintf at lib/Test/Moose/More.pm line 107.
    Test::Moose::More::does_not_ok("TestClass", "TestRole::Role", "wah-wah") called at t/does_not_ok.t line 34
ok 3 - TestClass: custom messages work as expected
Redundant argument in sprintf at lib/Test/Moose/More.pm line 107.
    Test::Moose::More::does_not_ok("TestRole", "TestRole::Role", "wah-wah") called at t/does_not_ok.t line 34
ok 4 - TestRole: custom messages work as expected
# single role, "complex" custom message - OK
ok 5 - TestClass: 'complex' custom messages work as expected
ok 6 - TestRole: 'complex' custom messages work as expected
# multiple roles, default message - OK
ok 7 - TestClass is found to not do the roles correctly
ok 8 - TestRole is found to not do the roles correctly
# multiple roles, custom message - OK
Redundant argument in sprintf at lib/Test/Moose/More.pm line 107.
    Test::Moose::More::does_not_ok("TestClass", ARRAY(0x7fe54c0307a0), "wah-wah") called at t/does_not_ok.t line 61
Redundant argument in sprintf at lib/Test/Moose/More.pm line 107.
    Test::Moose::More::does_not_ok("TestClass", ARRAY(0x7fe54c0307a0), "wah-wah") called at t/does_not_ok.t line 61
ok 9 - TestClass: multiple roles, custom messages work as expected
Redundant argument in sprintf at lib/Test/Moose/More.pm line 107.
    Test::Moose::More::does_not_ok("TestRole", ARRAY(0x7fe54d9507d8), "wah-wah") called at t/does_not_ok.t line 61
Redundant argument in sprintf at lib/Test/Moose/More.pm line 107.
    Test::Moose::More::does_not_ok("TestRole", ARRAY(0x7fe54d9507d8), "wah-wah") called at t/does_not_ok.t line 61
ok 10 - TestRole: multiple roles, custom messages work as expected
# multiple roles, "complex" custom message - OK
ok 11 - TestClass: multiple roles, 'complex' custom messages work as expected
ok 12 - TestRole: multiple roles, 'complex' custom messages work as expected
# role - NOT OK
ok 13 - TestClass::Fail is found to not do TestRole::Role correctly
ok 14 - TestRole::Fail is found to not do TestRole::Role correctly
# multiple roles - NOT OK
ok 15 - TestClass::Fail: multiple roles fail as expected
ok 16 - TestRole::Fail: multiple roles fail as expected
# multiple roles - PARTIALLY OK
ok 17 - TestClass::Fail2: multiple roles partially fail as expected
ok 18 - TestRole::Fail2: multiple roles partially fail as expected
1..18
: [ether@bourbon 1421624523.53187/Test-Moose-More-0.026]$; perl -Ilib -d:Confess t/does_ok.t 
# single role, default message - OK
ok 1 - TestClass is found to do TestRole::Role correctly
ok 2 - TestRole is found to do TestRole::Role correctly
# single role, custom message - OK
Redundant argument in sprintf at lib/Test/Moose/More.pm line 92.
    Test::Moose::More::does_ok("TestClass", "TestRole::Role", "wah-wah") called at t/does_ok.t line 37
ok 3 - TestClass: custom messages work as expected
Redundant argument in sprintf at lib/Test/Moose/More.pm line 92.
    Test::Moose::More::does_ok("TestRole", "TestRole::Role", "wah-wah") called at t/does_ok.t line 37
ok 4 - TestRole: custom messages work as expected
# single role, "complex" custom message - OK
ok 5 - TestClass: 'complex' custom messages work as expected
ok 6 - TestRole: 'complex' custom messages work as expected
# multiple roles, default message - OK
ok 7 - TestClass::Two is found to do the roles correctly
ok 8 - TestRole::Two is found to do the roles correctly
# multiple roles, custom message - OK
Redundant argument in sprintf at lib/Test/Moose/More.pm line 92.
    Test::Moose::More::does_ok("TestClass::Two", ARRAY(0x7fb61b830a10), "wah-wah") called at t/does_ok.t line 64
Redundant argument in sprintf at lib/Test/Moose/More.pm line 92.
    Test::Moose::More::does_ok("TestClass::Two", ARRAY(0x7fb61b830a10), "wah-wah") called at t/does_ok.t line 64
ok 9 - TestClass::Two: multiple roles, custom messages work as expected
Redundant argument in sprintf at lib/Test/Moose/More.pm line 92.
    Test::Moose::More::does_ok("TestRole::Two", ARRAY(0x7fb61d15a238), "wah-wah") called at t/does_ok.t line 64
Redundant argument in sprintf at lib/Test/Moose/More.pm line 92.
    Test::Moose::More::does_ok("TestRole::Two", ARRAY(0x7fb61d15a238), "wah-wah") called at t/does_ok.t line 64
ok 10 - TestRole::Two: multiple roles, custom messages work as expected
# multiple roles, "complex" custom message - OK
ok 11 - TestClass::Two: multiple roles, 'complex' custom messages work as expected
ok 12 - TestRole::Two: multiple roles, 'complex' custom messages work as expected
# role - NOT OK
ok 13 - TestClass::Fail is found to not do TestRole::Role correctly
ok 14 - TestRole::Fail is found to not do TestRole::Role correctly
# multiple roles - NOT OK
ok 15 - TestClass::Fail: multiple roles fail as expected
ok 16 - TestRole::Fail: multiple roles fail as expected
# multiple roles - PARTIALLY OK
ok 17 - TestClass::Fail2: multiple roles partially fail as expected
ok 18 - TestRole::Fail2: multiple roles partially fail as expected
1..18

rsrchboy added a commit that referenced this issue Jun 22, 2016
	* Eliminate a warning under v5.22+ (github #12)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants