Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ros2 api update #233

Merged
merged 2 commits into from
Oct 17, 2020
Merged

Conversation

SteveMacenski
Copy link
Collaborator

@SteveMacenski SteveMacenski commented Oct 9, 2020

#226

#215

Resolves these 2 tickets:

  • Removes goal checker condition, now the controller server takes care of this for you
  • Changes to the new weak pointer API

I just checked that things build, but this should not impact anything at runtime. If @garyrightbot would like to test to validate since they wanted this, that would be great.

@amakarow amakarow merged commit ca17d1d into rst-tu-dortmund:ros2-master Oct 17, 2020
@amakarow
Copy link
Contributor

Thank you. I merged this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants