Support Python 3.5 in version 0.95.1 #957
Conversation
pip will not install a Python 3 compatible version of rst2pdf (0.95+) due to classifiers we use in setup.py. This is a hotfix to 0.95, to create 0.95.1 that will allow a valid version of rst2pdf to be installed on older Linuxes that have Python 3.4 or 3.5 as their default.
|
Hmm... I'm not sure I can actually PR this as I don't want to merge it to master! This PR is therefore here for review purposes. |
|
I don't think this should go into |
|
That makes sense @stephenfin. I've created the |
This is consistent with our mainline development.
Backport of PR rst2pdf#870 (68d4ed7): > Inkscape 1.0 final has replaced the '--export-file' argument > with '--export-filename' [1]. Update our calls accordingly.
These generate different hashes each time for me on Python 3.4 and we removed vectorpdf in PR rst2pdf#896 for rstpdf 0.98.
akrabat
force-pushed
the
prepare-0.95.1
branch
from
c1dea96
to
6ee5094
Compare
This one is just too unrealiable!
This is no longer in rst2pdf so we didn't test Python 3.8 with this system before.
|
Looks like 0.95 won't work on Python 3.4 due to the Pillow 6.2 requirement. |
|
@akrabat why is Python 3.4 support needed? It's EOL for years now. Python 3.5 also, but some Enterprise linux still have it (although one should be able to install 3.6 from external RPM repositories). I think one can safely remove Python3.4 without hurting anyone. |
|
@oz123 See #955 (comment). For Debian Stretch, 3.5 is the current version, so supporting that seems wise. I'm not sure if any important distros ship with 3.4 or not, but the restraints in our requirements.txt mean that 3.4 isn't so simple anyway, so I was going to to ignore it. |
|
What's the status of this? I think we're aggreed that Python 3.5 is enough, and I see the base of the PR changed for that. It's approved, but not merged, do we have more do to here? (I am not sure how I would test this...) |
The version of pillow that we require doesn't work for Py 3.4, so do not imply that it works.
|
There's still something weird about the CI for Python 3.5 as it passed before I removed the 3.4 stuff. Merging and releasing anyway as it's better than not having it. |
akrabat
changed the title
|
🥳 |
pip will not install a Python 3 compatible version of rst2pdf (0.95+) due to classifiers we use in setup.py. This is a hotfix to 0.95, to create 0.95.1 that will allow a valid version of rst2pdf to be installed on older Linuxes that have Python 3.4 or 3.5 as their default.
To provide some level of confidence, I've added CI and have made it pass. I've had to ignore all the vectorpdf tests though as they generate different PDFs on each run and I don't know why. Checking locally, the PDFs created looked the same to me, so 🤷♀️. We have removed vectorpdf in 0.98 anyway, so I'm not concerned.
I also back-ported the Inkscape 1.0 fix so that I could test locally where the generated PDF was fine.
test_fancytitlesfails on CI, so I've just ignored it. Again, we've removed Inkscape from 0.98, so it's gone now anyway.GitHub Actions doesn't support Python 3.4, so I've left Travis in for that one, but it's very very slow.
Fixes #955