Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

capitalization fail ? #49

Closed
kranius opened this Issue Oct 11, 2011 · 2 comments

Comments

Projects
None yet
3 participants

kranius commented Oct 11, 2011

Hello,

simple expansion such as :

groupId{foobar}

will give :

groupid>foobar</groupid>

Case isn't kept.

Any tips on this ?

The problem is here: https://github.com/rstacruz/sparkup/blob/master/sparkup.py#L847

I understand that all html elements are lowercase, but I don't understand how anyone would accidentally type them uppercase.

If we want to support xml as a dialect, then shouldn't we just allow the user to set the case of the element characters however they want?

A slight advantage would be to allow more and more xml dialects where html for example would compare your tag to a dictionary of supported elements, and perhaps help syntastic warn you, and similar for Ant or Maven files or Apache config files.

In any case, random xml can have a tag named whatever, so I'd like that to be supported first.

Collaborator

faceleg commented Jan 29, 2014

There is a good possibility that you will be the only one using this plugin who wants this feature.

We accept pull requests.

@faceleg faceleg closed this Jan 29, 2014

nixon added a commit to nixon/sparkup that referenced this issue Nov 29, 2015

case insensitive expansions
fixes #49.

this may not be the desired behavior. html is case insensitive and
xhtml[1] states that html element and attribute names must be lower
case.

[1] http://www.w3.org/TR/xhtml1/#h-4.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment