Get rid of missing newline error in clang. #45
Conversation
|
I hope I can take a look at this within the next 2 weeks. |
|
I am unsure if always adding the new line will work on linux/win but the CI should error if it is indeed a problem. |
|
can you add "macos" to docs/source/spelling_dict.txt to fix the spelling check error |
tjni
force-pushed
the
osx-linux-cpp-newline-diff
branch
2 times, most recently
from
c84d32d
to
ff1ed39
Compare
Done! Fingers crossed. |
On Darwin, executing g++ runs clang, which emits an error when a C++ code block does not end in a newline. This is different from how g++ behaves on Linux. This error doesn't add any value in the context of a code block in an RST file, so we just always add a newline to the C++ source code of a block to always get rid of it.
tjni
force-pushed
the
osx-linux-cpp-newline-diff
branch
from
ff1ed39
to
edd6f42
Compare
|
Thanks for your work :) I would like to add pydantic v2 support before a new release. There is another PR already. Hope to get to it soon. |
|
Thank you for helping me merge this! Do you want me to open a PR on |
Yes, that would be very helpful. |
- 1.1 includes bugfixes for errors in clang rstcheck/rstcheck-core#45
On Darwin, executing g++ runs clang, which emits an error when a C++ code block does not end in a newline. This is different from how g++ behaves on Linux.
This error doesn't add any value in the context of a code block in an RST file, so we just always add a newline to the C++ source code of a block to get rid of it.
Check List
Resolves: #19
toxtest suite locally, so the CI pipelines should be green.