Update tests after rstcheck-core C++ change. #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rstcheck-core, we no longer return file does not end in a newline errors when checking C++ code blocks.
|
Thanks for the PR. Will let the PR run after the core release is out. No need for the Changelog update. |
|
rstcheck-core v1.1.0 just released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rstcheck-core, we no longer return file does not end in a newline errors when checking C++ code blocks.
Check List
This is a follow up to rstcheck/rstcheck-core#45 and can be merged when rstcheck-core is released. For tests, at least, the version constraint should be updated to allow that release (not done yet).
Should I update the CHANGELOG even though this is an internal CI change right now?
toxtest suite locally, so the CI pipelines should be green.