Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Update config loading hierarchy #96

Closed
Cielquan opened this issue Apr 18, 2022 · 0 comments
Closed

[Feature]: Update config loading hierarchy #96

Cielquan opened this issue Apr 18, 2022 · 0 comments
Assignees
@Cielquan
Labels
feature
Milestone
v6.0.0

Comments

@Cielquan
Copy link
Collaborator

Cielquan commented Apr 18, 2022 •
edited

Description

Currently the config file overwrites options set on the command line, which IMHO is not a good practice and rather confusing. Therefore this behavior need to be turned around.

The docs will need to be updated accordingly as well.

Also the hierarchy between config files is not stated -> which takes precedence over the other.
@Cielquan Cielquan self-assigned this Apr 18, 2022
@Cielquan Cielquan added this to the v6.0.0 milestone Apr 18, 2022
Cielquan added a commit that referenced this issue Apr 18, 2022
@Cielquan
state config file hierarchy; #96
147da00
weibullguy added a commit to weibullguy/rstcheck that referenced this issue Apr 18, 2022
@weibullguy
Merge remote-tracking branch 'upstream/master'
d4c440c 
* upstream/master: (35 commits)
  rename readme section to add FAQ
  whitespace
  add known limitations section; rstcheck#97
  whitespace
  cli args take precedence over config files; fixes rstcheck#96
  state config file hierarchy; rstcheck#96
  update changelog
  change back to code-block b/c of sphinx context
  guard directive remove actions
  remove cli option for sphinx defaults
  remove unused noqa
  allow code blocks to be ignored; fixes rstcheck#79
  fix types
  prewrap test resuls in dict for better introspection
  overwrite code-block and sourcecode directives without sphinx again
  remove code and code-block from sphinx ignore list
  load directives and roles from sphinx's docutils
  update extended default sphinx directives and roles
  drop sphinx default values
  add code-block to sphinx ignore roles
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cielquan Cielquan

Labels
feature
Projects
None yet
Milestone
v6.0.0
Development

No branches or pull requests
1 participant
@Cielquan