fixed eslint problems + compilation errors

examples/typescript-log4js/index.ts

@@ -1,5 +1,4 @@
 import {
-  LoggingEvent,
   configure,
   getLogger
 } from 'log4js'
@@ -51,7 +50,7 @@ slf4tsLogger.error('SLF4TS ERROR log message with error', new Error())
   .catch(console.log)
 
 slf4tsLogger.setMetadata({
-  user: (logEntry: LoggingEvent) => 'computed-value'
+  user: () => 'computed-value'
 })
 slf4tsLogger.trace('SLF4TS TRACE log message with number', 123)
   .catch(console.log)

packages/slf4ts-api/lib/slf4ts/LoggerBindings.ts

@@ -3,7 +3,7 @@ import 'source-map-support/register'
 import * as fs from 'fs'
 import * as path from 'path'
 
-import { LogLevel } from './LoggerConfiguration'
+import { type LogLevel } from './LoggerConfiguration'
 
 /**
  * Builds the instance of the underlying logger framework.
@@ -25,7 +25,7 @@ export interface LoggerImplementation<T, P extends any[]> {
      * @returns A Promise completed when the log statement was processed by the underlying logging-framework.
      * @memberof LoggerImplementation
      */
-  log(...args: any[]): Promise<any>
+  log: (...args: any[]) => Promise<any>
 
   /**
      * Gets the underlying implementation of the logger.
@@ -35,7 +35,7 @@ export interface LoggerImplementation<T, P extends any[]> {
      * @param {string} name The name of the logger.
      * @memberof LoggerImplementation
      */
-  getImplementation(group: string, name: string): T
+  getImplementation: (group: string, name: string) => T
 
   /**
      * Sets the configuration for the specified logger instance.
@@ -46,7 +46,7 @@ export interface LoggerImplementation<T, P extends any[]> {
      * @param {string} name The name of the logger.
      * @memberof LoggerImplementation
      */
-  setConfig<T>(config: T, group: string, name: string): void
+  setConfig: <T>(config: T, group: string, name: string) => void
 
   /**
      * Informs the logger implementation of the log-level change.
@@ -56,7 +56,7 @@ export interface LoggerImplementation<T, P extends any[]> {
      * @param {string} name The name of the logger.
      * @memberof LoggerImplementation
      */
-  setLogLevel(logLevel: LogLevel, group: string, name: string): void
+  setLogLevel: (logLevel: LogLevel, group: string, name: string) => void
 
   /**
      * Informs the logger implementation of the metadata change.
@@ -66,15 +66,15 @@ export interface LoggerImplementation<T, P extends any[]> {
      * @param {string} name The name of the logger.
      * @memberof LoggerImplementation
      */
-  setMetadata(metadata: any, group: string, name: string): void
+  setMetadata: (metadata: any, group: string, name: string) => void
 
   /**
    * Sets the logger builder instance
    *
    * @param {LoggerBuilder<T, P>} builder
    * @memberof LoggerImplementation
    */
-  setLoggerBuilder(builder: LoggerBuilder<T, P>): void
+  setLoggerBuilder: (builder: LoggerBuilder<T, P>) => void
 
 }
 
@@ -91,21 +91,21 @@ export interface LoggerBinding<T = any, P extends any[] = any> {
      * @returns {LoggerImplementation} The logger implementation.
      * @memberof LoggerBinding
      */
-  getLoggerImplementation(): LoggerImplementation<T, P>
+  getLoggerImplementation: () => LoggerImplementation<T, P>
   /**
      * Gets the vendor string.
      *
      * @returns {string} The vendor name.
      * @memberof LoggerBinding
      */
-  getVendor(): string
+  getVendor: () => string
   /**
      * Gets the version string.
      *
      * @returns {string} The version number.
      * @memberof LoggerBinding
      */
-  getVersion(): string
+  getVersion: () => string
 }
 
 /**
@@ -130,7 +130,7 @@ export class LoggerBindings {
      * @type {LoggerBinding[]}
      * @memberof LoggerBindings
      */
-  private readonly bindings: LoggerBinding[] = [];
+  private readonly bindings: LoggerBinding[] = []
 
   /**
      * Creates an instance of LoggerBindings.
@@ -140,18 +140,19 @@ export class LoggerBindings {
      */
   public constructor (additionalPaths: string[] = []) {
     if ('LOGGER_BINDING_ADDITIONAL_PATH' in process.env) {
-      additionalPaths.push(process.env.LOGGER_BINDING_ADDITIONAL_PATH)
+      additionalPaths.push(process.env.LOGGER_BINDING_ADDITIONAL_PATH ?? '')
     }
-    if ('mainModule' in process && 'paths' in process.mainModule) {
-      process.mainModule.paths
+    const mainModule = require.main ?? { paths: [], require: () => {} }
+    if ('mainModule' in process && 'paths' in mainModule) {
+      mainModule.paths
         .forEach((mainPath) => additionalPaths.push(mainPath))
     }
 
     const moduleFolders: string[] = this.getAllModuleFolders(additionalPaths)
     const loggerBindings: string[] = this.getAllLoggerBindings(moduleFolders)
 
     loggerBindings.forEach((binding) => {
-      const registerFunc = require.main.require(binding)
+      const registerFunc = mainModule.require(binding)
       registerFunc(this)
     })
   }
@@ -184,15 +185,14 @@ export class LoggerBindings {
      * @memberof LoggerBindings
      */
   public getBindings (): LoggerBinding[] {
-    return [].concat(this.bindings)
+    return this.bindings.slice()
   }
 
   private getAllModuleFolders (additionalPaths: string[]): string[] {
     const rootPaths: string[] = (module as any).paths
     const moduleFolders: string[] = []
 
-    rootPaths.concat(additionalPaths).forEach((rootPath) =>
-      this.visitNodeModules(rootPath).forEach((folder) => moduleFolders.push(folder)))
+    rootPaths.concat(additionalPaths).forEach((rootPath) => { this.visitNodeModules(rootPath).forEach((folder) => moduleFolders.push(folder)) })
 
     return moduleFolders
   }

packages/slf4ts-api/lib/slf4ts/LoggerConfiguration.ts

@@ -23,10 +23,10 @@ export enum LogLevel {
  * @class LoggerConfigurationImpl
  */
 export class LoggerConfigurationImpl {
-  private readonly events: EventEmitter = new EventEmitter();
-  private readonly logLevelMapping: Map<string, LogLevel> = new Map();
-  private readonly configMapping: Map<string, any> = new Map();
-  private defaultLogLevel: LogLevel = LogLevel.INFO;
+  private readonly events: EventEmitter = new EventEmitter()
+  private readonly logLevelMapping = new Map<string, LogLevel>()
+  private readonly configMapping = new Map<string, any>()
+  private defaultLogLevel: LogLevel = LogLevel.INFO
 
   /**
      * Gets the log-level for the given group and name.
@@ -42,7 +42,7 @@ export class LoggerConfigurationImpl {
     const compoundKey = `${group}:${name}`
 
     if (this.logLevelMapping.has(compoundKey)) {
-      return this.logLevelMapping.get(compoundKey)
+      return this.logLevelMapping.get(compoundKey) ?? this.defaultLogLevel
     }
 
     return this.defaultLogLevel

packages/slf4ts-api/lib/slf4ts/LoggerFactory.ts

@@ -1,6 +1,6 @@
 import 'source-map-support/register'
 
-import { LoggerBindings, LoggerImplementation, LoggerBuilder } from './LoggerBindings'
+import { LoggerBindings, type LoggerImplementation, type LoggerBuilder } from './LoggerBindings'
 import { LoggerConfiguration, LogLevel } from './LoggerConfiguration'
 
 /**
@@ -17,59 +17,59 @@ export interface ILoggerInstance<T> {
      * @returns {Promise<any>} A promise completing when the logging-implementation processed the log statement.
      * @memberof ILoggerInstance
      */
-  trace(...args: any[]): Promise<any>
+  trace: (...args: any[]) => Promise<any>
   /**
      * Logs the given message using DEBUG log-level.
      *
      * @param {...args: any[]} [args] messages, metadata and errors to log.
      * @returns {Promise<any>} A promise completing when the logging-implementation processed the log statement.
      * @memberof ILoggerInstance
      */
-  debug(...args: any[]): Promise<any>
+  debug: (...args: any[]) => Promise<any>
   /**
      * Logs the given message using INFO log-level.
      *
      * @param {...args: any[]} [args] messages, metadata and errors to log.
      * @returns {Promise<any>} A promise completing when the logging-implementation processed the log statement.
      * @memberof ILoggerInstance
      */
-  info(...args: any[]): Promise<any>
+  info: (...args: any[]) => Promise<any>
   /**
      * Logs the given message using WARN log-level.
      *
      * @param {...args: any[]} [args] messages, metadata and errors to log.
      * @returns {Promise<any>} A promise completing when the logging-implementation processed the log statement.
      * @memberof ILoggerInstance
      */
-  warn(...args: any[]): Promise<any>
+  warn: (...args: any[]) => Promise<any>
   /**
      * Logs the given message using ERROR log-level.
      *
      * @param {...args: any[]} [args] messages, metadata and errors to log.
      * @returns {Promise<any>} A promise completing when the logging-implementation processed the log statement.
      * @memberof ILoggerInstance
      */
-  error(...args: any[]): Promise<any>
+  error: (...args: any[]) => Promise<any>
   /**
      * Gets the current log-level.
      *
      * @returns {LogLevel} The log-level.
      * @memberof ILoggerInstance
      */
-  getLogLevel(): LogLevel
+  getLogLevel: () => LogLevel
   /**
      * Sets the metadata assigned to every future invocation of any of the log-methods.
      *
      * @param {*} metadata metadata object - can be undefined or null.
      * @memberof ILoggerInstance
      */
-  setMetadata(metadata: any): void
+  setMetadata: (metadata: any) => void
   /**
      * Gets the underlying implementation of the logger.
      *
      * @memberof ILoggerInstance
      */
-  getImplementation(): T
+  getImplementation: () => T
 }
 
 /**
@@ -80,11 +80,11 @@ export interface ILoggerInstance<T> {
  * @implements {ILoggerInstance}
  */
 export class DefaultLoggerInstance<T, P extends any[]> implements ILoggerInstance<T> {
-  private readonly impl: LoggerImplementation<T, P>;
-  private readonly name: string;
-  private readonly group: string;
-  private commonMetadata: any;
-  private logLevel: LogLevel;
+  private readonly impl: LoggerImplementation<T, P>
+  private readonly name: string
+  private readonly group: string
+  private commonMetadata: any
+  private logLevel: LogLevel
 
   /**
      * Creates an instance of DefaultLoggerInstance.
@@ -183,7 +183,7 @@ export class DefaultLoggerInstance<T, P extends any[]> implements ILoggerInstanc
     if (logLevel <= this.logLevel) {
       return this.impl.log.apply(this.impl, arguments)
     }
-    return Promise.resolve()
+    await Promise.resolve()
   }
 }
 
@@ -193,7 +193,7 @@ export class DefaultLoggerInstance<T, P extends any[]> implements ILoggerInstanc
  * @class NullLoggerImplementation
  * @implements {LoggerImplementation}
  */
-class NullLoggerImplementation implements LoggerImplementation<null, null> {
+class NullLoggerImplementation implements LoggerImplementation<null, any[]> {
   public async log (...args: any[]): Promise<any> {
     return null
   }
@@ -214,7 +214,7 @@ class NullLoggerImplementation implements LoggerImplementation<null, null> {
     // nothing
   }
 
-  public setLoggerBuilder (builder: LoggerBuilder<null, null>): void {
+  public setLoggerBuilder (builder: LoggerBuilder<null, any[]>): void {
     // nothing
   }
 }
@@ -250,13 +250,14 @@ export class LoggerFactory {
       return LoggerFactory.LOGGER_INSTANCE_CACHE.get(compoundKey) as ILoggerInstance<T>
     }
 
+    const defaultLoggerBuilder: LoggerBuilder<T, P> = () => null as T
     const instance = new DefaultLoggerInstance<T, P>(
       name,
       group,
       LoggerConfiguration.getLogLevel(group, name),
       LoggerFactory.COMMON_METADATA,
       LoggerFactory.LOGGER as LoggerImplementation<T, P>,
-      builder)
+      builder ?? defaultLoggerBuilder)
     LoggerFactory.LOGGER_INSTANCE_CACHE.set(compoundKey, instance)
     return instance
   }
@@ -310,11 +311,11 @@ export class LoggerFactory {
     })
   }
 
-  private static COMMON_METADATA: any = undefined;
-  private static LOGGER: LoggerImplementation<unknown, unknown[]> = new NullLoggerImplementation();
-  private static ROOT_LOGGER: DefaultLoggerInstance<unknown, unknown[]>;
-  private static INITIALIZED: boolean = false;
-  private static readonly LOGGER_INSTANCE_CACHE: Map<string, DefaultLoggerInstance<unknown, unknown[]>> = new Map();
+  private static COMMON_METADATA: any = undefined
+  private static LOGGER: LoggerImplementation<unknown, unknown[]> = new NullLoggerImplementation()
+  private static ROOT_LOGGER: DefaultLoggerInstance<unknown, unknown[]>
+  private static INITIALIZED: boolean = false
+  private static readonly LOGGER_INSTANCE_CACHE = new Map<string, DefaultLoggerInstance<unknown, unknown[]>>()
 
   private static initialize<T, P extends any[]>(): void {
     const BINDINGS = new LoggerBindings().getBindings()

packages/slf4ts-api/test/slf4ts/LoggerBindingTest.ts

@@ -13,7 +13,7 @@ const expect = chai.expect
 // hack to re-initialize the path for module resolution
 const nodeModuleExtraPath = path.join(__dirname, '..', '..', 'example-node-modules')
 process.env.NODE_PATH = nodeModuleExtraPath
-require('module').Module._initPaths()
+require('module').Module._initPaths() // eslint-disable-line @typescript-eslint/no-var-requires
 
 @suite
 export class LoggerBindingsTest {

packages/slf4ts-api/test/slf4ts/LoggerFactoryTest.ts

@@ -8,7 +8,7 @@ import { suite, test } from '@testdeck/mocha'
 import * as path from 'path'
 
 import { LoggerConfiguration, LogLevel } from '../../lib/slf4ts/LoggerConfiguration'
-import { DefaultLoggerInstance, LoggerFactory } from '../../lib/slf4ts/LoggerFactory'
+import { type DefaultLoggerInstance, LoggerFactory } from '../../lib/slf4ts/LoggerFactory'
 
 const expect = chai.expect
 const fail = chai.assert.fail
@@ -17,7 +17,7 @@ const fail = chai.assert.fail
 const nodeModuleExtraPath = path.join(__dirname, '..', '..', 'example-node-modules')
 process.env.NODE_PATH = nodeModuleExtraPath
 process.env.LOGGER_BINDING_ADDITIONAL_PATH = nodeModuleExtraPath
-require('module').Module._initPaths()
+require('module').Module._initPaths() // eslint-disable-line @typescript-eslint/no-var-requires
 
 @suite
 export class LoggerFactoryTest {

packages/slf4ts-bunyan/lib/slf4ts/BunyanLoggerBinding.ts

@@ -2,8 +2,8 @@ import 'source-map-support/register'
 
 import * as fs from 'fs'
 import * as path from 'path'
-import * as Logger from 'bunyan'
-import { LoggerBinding } from 'slf4ts-api'
+import type * as Logger from 'bunyan'
+import { type LoggerBinding } from 'slf4ts-api'
 
 import { BunyanLoggerImplementation } from './BunyanLoggerImplementation'
 
@@ -15,7 +15,7 @@ import { BunyanLoggerImplementation } from './BunyanLoggerImplementation'
  * @implements {LoggerBinding}
  */
 export class BunyanLoggerBinding implements LoggerBinding<Logger, [Logger.LoggerOptions]> {
-  private readonly packageJson: any;
+  private readonly packageJson: any
 
   public constructor () {
     const modulePath = path.parse(module.filename)