Fix extra_dependencies handling in gitbook() #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cderv
approved these changes
Feb 27, 2023
There was a problem hiding this comment.
😮 good finding ! this is really something missing. This means that all of the previous fix we did in #1101 was indeed not working. We should have waited for confirmation before merging.
I think we need to add a small tests to this PR to confirm. Thanks a lot for this !
cderv
changed the title
|
Here is set of working examples with bookdown combined with another style . I use this collection of documents to test our corporate identity. Working on INBOmd is how I found this problem. |
|
Awesome. Would that be ok to use this repo in our CI checks so that we can test if a new bookdown version is breaking something ? |
|
Sure. That's why we make them public with a open source license. |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation ignores
extra_dependenciespassed togitbook().