Change name of temporary files created. #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, during rending the code copies the backs up the R markdown file to a temporary file in the same directory with the a name like `bookdown11b6326822f9c`. This file should be cleaned up, but sometimes is not if the process is killed. If the file happens to not be cleaned up, it is hard to write a globbing expression for `.gitignore` and similar to match it that and wouldn't result in false positives; `bookdown*` is the best I can come up with. I propose 1. Use a `.bak` extension to make it easier to match with globbing. 2. Use the original filename as the base, since it is backing up a particular file. If the process is killed, then it is easier to restore the original file. Alternatively, if the backup file never needs to be restored by the user, why not put it in the temporary directory? Addresses rstudio#612
yihui
reviewed
Aug 13, 2018
Don't overwrite user filenames See comment in rstudio#613
|
That's fine with me; the new commit makes that change. Is there a reason the backup file has to be in the working directory? It's only used for backup and not execution. |
|
To make it easier to restore the file if anything goes wrong (e.g. R crashed). If it is in the |
yihui
approved these changes
Aug 14, 2018
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, during rending the code copies the backs up the R markdown file to a temporary file in the same directory with the a name like
bookdown11b6326822f9c. This file should be cleaned up, but sometimes is not if the process is killed. If the file happens to not be cleaned up, it is hard to write a globbing expression for.gitignoreand similar to match it that and wouldn't result in false positives;bookdown*is the best I can come up with. I propose.bakextension to make it easier to match with globbing.Alternatively, if the backup file never needs to be restored by the user, why not put it in the temporary directory?
Addresses #612