Test result api fixes#60 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
|
schloerke
requested changes
Aug 14, 2019
| #' 2/2 correct! Absolutely fabulous!. | ||
| #' @param glue_incorrect A glue string that returns the final correct message displayed. | ||
| #' Defaults to \code{getOption("gradethis_glue_correct_test")}, e.g., | ||
| #' 1/2 correct! Try it again; next time's the charm!. |
There was a problem hiding this comment.
missing code and quotes.
\code{"1/2 correct! ... "}
There was a problem hiding this comment.
Will make the change in #68
R/test_result.R
Outdated
| return(evaluated_condi) | ||
|
|
||
| } else { # evaluating a fail_if condition # nolint | ||
| if (is.null(evaluated_condi)) { |
There was a problem hiding this comment.
I believe this if/else can be replaced with
evaluated_condi <- evaluated_condi %||% graded(correct = TRUE, message = NULL)A passing fail_if returns a graded(correct = FALSE, message = MESSAGE) object.
There was a problem hiding this comment.
oh you're right! I just wrote it super explicitly to not make my brain hurt.
I should update the docs about that too...
small doc changes for pkgdown doc fixes rebase/fix conflicts/fix docs for R CMD check things to stash (broken) test_result implementation + tests fixes #60 rename test files for consistency doc updates (mainly test_result) refactor conditional flip for loop to map call
chendaniely
force-pushed
the
test_result_api_fixes#60
branch
from
f40511d
to
3b1661c
Compare
schloerke
reviewed
Aug 15, 2019
R/evaluate_condition.R
Outdated
| @@ -1,4 +1,4 @@ | |||
| #' Evaluates a condition | |||
| #' Evaluates a conditio | |||
archive/view_tutorial.R
Outdated
| @@ -12,7 +12,10 @@ | |||
| #' | |||
| #' TODO need to export when feature is implement in RStudio IDE | |||
| #' @noRd | |||
| <<<<<<< HEAD:archive/view_tutorial.R | |||
Merged
schloerke
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be rebased after #62 gets merged.
Implements the changes for
test_result