Skip to content

Commit

Permalink
Merge branch 'master' into fmt-fraction
Browse files Browse the repository at this point in the history
* master:
  Change HTML percent sign to literal `%` (#871)
  Update gt_workflow_diagram.svg
  Update gt_parts_of_a_table.svg
  Update README.md
  Add dedicated ISSUE TEMPLATEs
  Update README.md
  Delete README.Rmd
  Update intro-creating-gt-tables.Rmd
  Update LICENSE
  Make corrections to docs (`columns`/`rows`)
  Update _pkgdown.yml
  • Loading branch information
rich-iannone committed Feb 2, 2022
2 parents 380b4cb + 86014db commit 6a8a516
Show file tree
Hide file tree
Showing 34 changed files with 462 additions and 537 deletions.
15 changes: 0 additions & 15 deletions .github/ISSUE_TEMPLATE.md

This file was deleted.

35 changes: 35 additions & 0 deletions .github/ISSUE_TEMPLATE/bug.md
@@ -0,0 +1,35 @@
---
name: Bug
about: Something is wrong with gt.
title: ''
labels: 'Type: ☹︎ Bug'
assignees: rich-iannone
---

## Prework

* [ ] Read and agree to the [code of conduct](https://www.contributor-covenant.org/version/2/0/code_of_conduct/) and [contributing guidelines](https://github.com/rstudio/gt/blob/master/.github/CONTRIBUTING.md).
* [ ] If there is [already a relevant issue](https://github.com/rstudio/gt/issues), whether open or closed, comment on the existing thread instead of posting a new issue.
* [ ] Post a [minimal reproducible example](https://www.tidyverse.org/help/) so the maintainer can troubleshoot the problems you identify. A reproducible example is:
* [ ] **Runnable**: post enough R code and data so any onlooker can create the error on their own computer.
* [ ] **Minimal**: reduce runtime wherever possible and remove complicated details that are irrelevant to the issue at hand.
* [ ] **Readable**: format your code according to the [tidyverse style guide](https://style.tidyverse.org/).

## Description

Describe the bug clearly and concisely.

## Reproducible example

* [ ] Post a [minimal reproducible example](https://www.tidyverse.org/help/) so the maintainer can troubleshoot the problems you identify. A reproducible example is:
* [ ] **Runnable**: post enough R code and data so any onlooker can create the error on their own computer.
* [ ] **Minimal**: reduce runtime wherever possible and remove complicated details that are irrelevant to the issue at hand.
* [ ] **Readable**: format your code according to the [tidyverse style guide](https://style.tidyverse.org/).

## Expected result

What should have happened? Please be as specific as possible.

## Session info

End the reproducible example with a call to `sessionInfo()` in the same session (e.g. `reprex(session_info = TRUE)`) and include the output.
18 changes: 18 additions & 0 deletions .github/ISSUE_TEMPLATE/feature.md
@@ -0,0 +1,18 @@
---
name: New feature
about: Suggest a new feature.
title: ''
labels: 'Type: ★ Enhancement'
assignees: rich-iannone
---

## Prework

- [ ] Read and abide by **gt**'s [code of conduct](https://www.contributor-covenant.org/version/2/0/code_of_conduct/) and [contributing guidelines](https://github.com/rstudio/gt/blob/master/.github/CONTRIBUTING.md).
- [ ] Search for duplicates among the [existing issues](https://github.com/rstudio/gt/issues) (both open and closed).

## Proposal

Describe the new feature clearly and concisely. If applicable, write a minimal example in R code or pseudo-code to show input, usage, and desired output.

To help us read any code you include (optional) please try to follow the [tidyverse style guide](https://style.tidyverse.org/). The `style_text()` and `style_file()` functions from the [`styler`](https://github.com/r-lib/styler) package make it easier.
27 changes: 27 additions & 0 deletions .github/ISSUE_TEMPLATE/question.md
@@ -0,0 +1,27 @@
---
name: Question
about: Ask a question.
title: ''
labels: 'Type: ⁇ Question'
assignees: ''
---

## Prework

* [ ] Read and agree to the [code of conduct](https://www.contributor-covenant.org/version/2/0/code_of_conduct/) and [contributing guidelines](https://github.com/rstudio/gt/blob/master/.github/CONTRIBUTING.md).
* [ ] If there is [already a relevant issue](https://github.com/rstudio/gt/issues), whether open or closed, comment on the existing thread instead of posting a new issue.
* [ ] For any problems you identify, a [minimal reproducible example](https://www.tidyverse.org/help/) so the maintainer can troubleshoot. A reproducible example is:
* [ ] **Runnable**: post enough R code and data so any onlooker can create the error on their own computer.
* [ ] **Minimal**: reduce runtime wherever possible and remove complicated details that are irrelevant to the issue at hand.
* [ ] **Readable**: format your code according to the [tidyverse style guide](https://style.tidyverse.org/).

## Question

What would you like to know?

## Reproducible example

* [ ] For any problems you identify, post a [minimal reproducible example](https://www.tidyverse.org/help/) so the maintainer can troubleshoot. A reproducible example is:
* [ ] **Runnable**: post enough R code and data so any onlooker can create the error on their own computer.
* [ ] **Minimal**: reduce runtime wherever possible and remove complicated details that are irrelevant to the issue at hand.
* [ ] **Readable**: format your code according to the [tidyverse style guide](https://style.tidyverse.org/).
2 changes: 1 addition & 1 deletion LICENSE
@@ -1,2 +1,2 @@
YEAR: 2018-2021
YEAR: 2018-2022
COPYRIGHT HOLDER: RStudio, PBC
2 changes: 1 addition & 1 deletion LICENSE.md
@@ -1,6 +1,6 @@
The MIT License (MIT)

Copyright (c) 2018-2021 RStudio, PBC
Copyright (c) 2018-2022 RStudio, PBC

Permission is hereby granted, free of charge, to any person
obtaining a copy of this software and associated documentation
Expand Down
6 changes: 3 additions & 3 deletions R/format_data.R
Expand Up @@ -30,9 +30,9 @@
#' focused on selections. The select helper functions are: [starts_with()],
#' [ends_with()], [contains()], [matches()], [one_of()], [num_range()], and
#' [everything()].
#' @param rows Optional rows to format. Providing either [everything()] (the
#' default) or `TRUE` results in all rows in `columns` being formatted. Can
#' either be a vector of row captions provided in [c()], a vector of row
#' @param rows Optional rows to format. Providing [everything()] (the
#' default) results in all rows in `columns` being formatted. Alternatively,
#' we can supply a vector of row captions within [c()], a vector of row
#' indices, or a helper function focused on selections. The select helper
#' functions are: [starts_with()], [ends_with()], [contains()], [matches()],
#' [one_of()], [num_range()], and [everything()]. We can also use expressions
Expand Down
6 changes: 3 additions & 3 deletions R/modify_columns.R
Expand Up @@ -146,7 +146,7 @@ cols_align <- function(data,
#' Subsequent expressions that operate on the columns assigned previously will
#' result in overwriting column width values (both in the same `cols_width()`
#' call and across separate calls). All other columns can be assigned a
#' default width value by using `TRUE` or `everything()` on the left-hand
#' default width value by using `everything()` on the left-hand
#' side.
#' @param .list Allows for the use of a list as an input alternative to `...`.
#'
Expand All @@ -157,8 +157,8 @@ cols_align <- function(data,
#' # with named arguments in `...`, we
#' # can specify the exact widths for
#' # table columns (using `everything()`
#' # or `TRUE` at the end will capture
#' # all remaining columns)
#' # at the end will capture all
#' # remaining columns)
#' tab_1 <-
#' exibble %>%
#' dplyr::select(
Expand Down
2 changes: 1 addition & 1 deletion R/utils_formatters.R
Expand Up @@ -450,7 +450,7 @@ context_minus_mark <- function(context) {
context_percent_mark <- function(context) {

switch(context,
html = "&percnt;",
html = "%",
latex = "\\%",
"%")
}
Expand Down
143 changes: 0 additions & 143 deletions README.Rmd

This file was deleted.

0 comments on commit 6a8a516

Please sign in to comment.