Skip to content

Change HTML percent sign to literal %#871

Merged
rich-iannone merged 3 commits intomasterfrom
change-percent-mark
Feb 1, 2022
Merged

Change HTML percent sign to literal %#871
rich-iannone merged 3 commits intomasterfrom
change-percent-mark

Conversation

@rich-iannone
Copy link
Member

@rich-iannone rich-iannone commented Feb 1, 2022

This PR reverts the HTML percent mark from % to %. There is an issue (#686) where this HTML entity is problematic for some users who are using gt tables in different contexts (e.g., Outlook email and Shiny/R Markdown).

Fixes: #686
Fixes: #657

@rich-iannone rich-iannone requested a review from jcheng5 February 1, 2022 15:23
@rich-iannone rich-iannone merged commit 86014db into master Feb 1, 2022
@rich-iannone rich-iannone deleted the change-percent-mark branch February 1, 2022 21:39
rich-iannone added a commit that referenced this pull request Feb 1, 2022
* master:
  Change HTML percent sign to literal `%` (#871)
  Update gt_workflow_diagram.svg
  Update gt_parts_of_a_table.svg
  Update README.md
  Add dedicated ISSUE TEMPLATEs
  Update README.md
  Delete README.Rmd
  Update intro-creating-gt-tables.Rmd
  Update LICENSE
  Make corrections to docs (`columns`/`rows`)
  Update _pkgdown.yml
rich-iannone added a commit that referenced this pull request Feb 2, 2022
* master:
  Change HTML percent sign to literal `%` (#871)
  Update gt_workflow_diagram.svg
  Update gt_parts_of_a_table.svg
  Update README.md
  Add dedicated ISSUE TEMPLATEs
  Update README.md
  Delete README.Rmd
  Update intro-creating-gt-tables.Rmd
  Update LICENSE
  Make corrections to docs (`columns`/`rows`)
  Update _pkgdown.yml
rich-iannone added a commit that referenced this pull request Feb 2, 2022
* master: (23 commits)
  Improve color handling and add tests (#870)
  Change HTML percent sign to literal `%` (#871)
  Add ability to set global locale in `gt()` (#866)
  Bug fixes and enhancements to date/time formatters (#801)
  Update gt_workflow_diagram.svg
  Update gt_parts_of_a_table.svg
  Update README.md
  Add dedicated ISSUE TEMPLATEs
  Update README.md
  Delete README.Rmd
  Update intro-creating-gt-tables.Rmd
  Update LICENSE
  Make corrections to docs (`columns`/`rows`)
  Update _pkgdown.yml
  Fixes to footer (footnotes and source notes) across all output formats (#864)
  Row group labels as a column in stub (#855)
  Use reusable GHA workflows (#847)
  Increment version number
  v0.3.1 Release Candidate (#821)
  Fix for styles applied to summary cells when row groups are reordered (#814)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: have option of using literal "%" instead of "%". Issue with rendering % with as_raw_html in Email

2 participants