Transform certain X11 colors with no CSS equivalent #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Add the `force_sign` arg to several numeric formatters (#793)
|
Open question:
|
|
Named CSS3 colors are now detected and normalized to hexadecimal values before hitting |
jcheng5
reviewed
Jun 15, 2021
R/data_color.R
Outdated
| # translate certain color names (CSS exclusive names) if necessary | ||
| if (!all(grepl("^#", colors))) { | ||
|
|
||
| named_colors <- tolower(colors[!grepl("^#", colors)]) |
There was a problem hiding this comment.
Simplify conditional logic (both 378 and 382) by reusing the variable you'll need anyway.
jcheng5
reviewed
Jun 15, 2021
R/data_color.R
Outdated
| if (any(named_colors %in% css_exclusive_color_names())) { | ||
|
|
||
| colors <- | ||
| vapply( |
* master: Add padding options for heading and column labels (#795)
jcheng5
reviewed
Jun 18, 2021
R/data_color.R
Outdated
| colors[is_css_excl_named] <- | ||
| names( | ||
| css_exclusive_color_names()[ | ||
| match(tolower(colors[is_css_excl_named]), css_exclusive_color_names()) |
There was a problem hiding this comment.
Switch css_exclusive_color_names's names to values and values to names
jcheng5
reviewed
Jun 18, 2021
jcheng5
reviewed
Jun 18, 2021
jcheng5
reviewed
Jun 22, 2021
R/data_color.R
Outdated
Comment on lines
412
to
414
| unname( | ||
| css_exclusive_colors()[ | ||
| match(colors[is_css_excl_named], names(css_exclusive_colors())) |
There was a problem hiding this comment.
Suggested change
| unname( | |
| css_exclusive_colors()[ | |
| match(colors[is_css_excl_named], names(css_exclusive_colors())) | |
| unname(css_exclusive_colors()[colors[is_css_excl_named]]) |
jcheng5
approved these changes
Jun 22, 2021
rich-iannone
added a commit
that referenced
this pull request
Jun 22, 2021
* master: Transform certain X11 colors with no CSS equivalent (#787)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intercepts named colors just before sass compilation and replaces X11 color names with no CSS color equivalent with a hexadecimal color. This should likely be done in more places where colors serve as inputs (e.g.,
cell_fill()) being careful to only apply the transformation in the HTML context.The X11 color names that don't work as CSS color names are the shades of gray (e.g.,
gray1,gray85,grey50, etc.). The ones that do work but yield small-to-large differences between X11 and CSS are the numbered variants in some colors (e.g.,Azure2, etc.).Fortunately, the gt package has a utility function to handle the conversion from X11 color name to hexadecimal color code (
html_color()). This is used only in those cases where X11 colors need transformation.Fixes: #712