New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the data
arg to .data
to avoid partial matching issues
#772
Conversation
Let's check |
The The |
* master: Add the `force_sign` arg to several numeric formatters (#793)
Changes have now been made to limit the |
* master: (24 commits) Fix for possible column name duplication when generating summary rows (#792) Change the `data` arg to `.data` to avoid partial matching issues (#772) Add the `force_sign` arg to several numeric formatters (#793) Add the `fmt_engineering()` and `fmt_integer()` formatter functions (#758) HTML summary row styling fix (#782) Refactor and improve rendering of title/subtitle components in HTML/LaTeX tables (#779) LaTeX bugfix for summary rows, and, implementation of grand summary rows (#768) Reinstate once failing test Include stub var in resolution of visible vars Use `seq_len()` instead of `seq()` Fix typo in README (#765) Increment version number (#762) Increase version number Documentation fixes (#759) Add missing topics to _pkgdown.yml Add `accounting` options for `fmt_percent()` and `fmt_number()` (#756) Simplify arguments for RTF page numbering Add the `fmt_bytes()` formatter function (#750) Simplify page numbering text Add testthat snapshot tests for RTF page numbering ...
In functions like
cols_label()
, having a column name close todata
may result in a partial matching error. Here's a reproducible example of the error:This can be solved by changing the argument name to
.data
. For consistency, all instances ofdata
as argument names in exported functions were changed to.data
.On the user side, there should hopefully be little disruption as all examples and ways of using the gt API don't use the argument name
data
(either via piping or through implicit use ofdata
when just usinggt()
).Fixes: #715