Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip filename encoding tests on non-UTF-8 Unix platforms #265

Merged
merged 1 commit into from
May 4, 2020

Conversation

wch
Copy link
Collaborator

@wch wch commented May 4, 2020

Resolves #264.

To verify:

docker run --security-opt seccomp=unconfined --rm -ti rocker/r-devel /bin/bash

apt install -y git libssl-dev vim nano

echo en_US ISO-8859-1 >> /etc/locale.gen
locale-gen

echo MAKEFLAGS=-j4 > ~/.Renviron

git clone https://github.com/rstudio/httpuv.git
RD -e "install.packages('remotes')"
RD -e 'remotes::install_deps("httpuv", dependencies = TRUE)'

export LANG=en_US.iso88591
# This prints a warning, but it seems to be necessary for things to work.
export LC_ALL=en_US.iso88591

RD --quiet -e 'Sys.getlocale()'

# Get the right branch
cd httpuv
git checkout  wch-filename-encoding
cd ..

RD CMD build httpuv
R CMD check httpuv_1.5.2.9000.tar.gz 

This will pass, but if you check out the master branch, it will fail.

@wch wch requested a review from jcheng5 May 4, 2020 20:49
@wch wch merged commit e0554bd into master May 4, 2020
@wch wch deleted the wch-filename-encoding branch May 4, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on Latin1 locale on Debian
3 participants