Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tileOptions() to addRasterImage() #508

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

eduardszoecs
Copy link

This is a fix for #507 and deals more generally with tileOptions in addRasterImage().
The issue also links to other related issues in downstream packages.

The PR is backward compatible and raises a deprecation warning for the now overfluous arguments opacity and attribution.

PR task list:

  • Update NEWS
  • Add tests (if appropriate) [not appropriate? didn't find any existing tests]
  • Update documentation with devtools::document()

@eduardszoecs
Copy link
Author

but you've directly changed inst/htmlwidgets/leaflet.js which is not the way to go about it.
inst/htmlwidgets/leaflet.js is now auto generated and should not be directly edited. You need to change src/javascript/methods.js and then run grunt build from the project root.

I think this applies also for this PR (sorry for that) :( Will fix asap.

@eduardszoecs
Copy link
Author

running grunt build doesn't change anything, so PR is fine (=my manual changes to inst/htmlwidgets/leaflet.js seem to reflect grunt build).

@schloerke
Copy link
Contributor

Hi @Edild

Could you ...

"
2. Ensure that you have signed the individual or corporate contributor agreement as appropriate. You can send the signed copy to jj@rstudio.com.
"
Excerpt from rstudio/httpuv package, which you had no reason to know existed.

Please let me know when you've sent the email. Thank you for your help!

Best,
Barret

@schloerke schloerke self-assigned this Apr 16, 2018
@eduardszoecs
Copy link
Author

Thanks. Will submit asap - need to check if individual or corporate one applies here.

@eduardszoecs
Copy link
Author

@schloerke Done!

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tim-salabim tim-salabim mentioned this pull request Jul 4, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants