Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch leaflet.css with missing rule about <img> in pane #770

Merged
merged 2 commits into from Feb 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion NEWS
Expand Up @@ -7,7 +7,7 @@ FEATURES
BUG FIXES and IMPROVEMENTS
* Enable JS function literals (wrapped in `htmlwidgets::JS()`) to be included in arguments to methods invoked on `leafletProxy` objects. (JS function literals could already be included with methods invoked on `leaflet` objects, so this change just brings `leafletProxy` to parity.) (#420)


* Add missing CSS rule to show `<img>` in right-pane and left-pane (rstudio/rmarkdown/issues#1949).

leaflet 2.0.4.1
--------------------------------------------------------------------------------
Expand Down
9 changes: 9 additions & 0 deletions inst/htmlwidgets/lib/rstudio_leaflet/rstudio_leaflet.css
Expand Up @@ -30,3 +30,12 @@
.leaflet-map-pane {
z-index: auto;
}

/* Add missing rule from leaflet for img.
This complete existing leaflet.css.
Fix for https://github.com/rstudio/rmarkdown/issues/1949 */
.leaflet-container .leaflet-right-pane img,
.leaflet-container .leaflet-left-pane img {
max-width: none !important;
max-height: none !important;
}