Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make shiny modules for quiz questions (instead of htmlwidgets) #194

Merged
merged 67 commits into from Apr 9, 2019
Merged
Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
67 commits
Select commit Hold shift + click to select a range
463d389
First pass at making a radio shiny app. Commenting for now to see cha…
schloerke Oct 5, 2018
3cec06a
encode quiz question / answer text to be UTF-8
schloerke Oct 5, 2018
ad14f17
first pass at abstract radio shiny app
schloerke Oct 5, 2018
7d5f965
add checkbox to shiny app questions
schloerke Oct 5, 2018
15c9b51
always display the default incorrect / correct message in addition to…
schloerke Oct 5, 2018
02919e0
first pass at a text input question
schloerke Oct 5, 2018
fa073eb
add the option back to the answer object for legacy
schloerke Oct 5, 2018
3a120c4
Merge remote-tracking branch 'upstream/master' into text_answer
schloerke Oct 8, 2018
2463f1d
Merge branch 'master' into text_answer
schloerke Oct 8, 2018
d62f2ae
ignore atom config folder for local settings
schloerke Oct 10, 2018
1b0c52f
failed attempt to use raw shiny module. moving towards using a `rmark…
schloerke Oct 11, 2018
e27cc8f
use dput_to_string instead of list_to_string
schloerke Oct 15, 2018
9027b0b
checkbox is working with simpler s3 method calls and leveraging shiny…
schloerke Oct 15, 2018
290ef52
checkbox and text questions work (without disable)
schloerke Oct 15, 2018
90ccf08
questions do not depend upon shinyjs to disable elements
schloerke Oct 16, 2018
949e424
move slickquiz / slickquiz tutorial css to rstudio-theme
schloerke Oct 16, 2018
f8a6dda
comments for mutate_tags
schloerke Oct 16, 2018
77494a3
do not double encode quiz_text content
schloerke Oct 16, 2018
be384d7
use knit_print.question and not question_to_shiny
schloerke Oct 16, 2018
0762487
add more TODOs
schloerke Oct 17, 2018
b0011ee
submit question submission event
schloerke Oct 17, 2018
824a3af
more todos
schloerke Oct 18, 2018
28def3f
make sure answers submitted are not generated with random ids
schloerke Oct 18, 2018
0b6ecd9
get a prior submission for a given question
schloerke Oct 18, 2018
b5d63af
rewrite question reactivity to depend only on submitted answer
schloerke Oct 18, 2018
6319e5c
set up userData$learnr_state
schloerke Oct 18, 2018
043a0c1
allow for local development to work as localhost
schloerke Oct 18, 2018
6fc7ae6
default the ui to display "loading..." - Seems better than a pure ver…
schloerke Oct 18, 2018
4361bd0
add temp sleep command to visually see "loading..."
schloerke Oct 18, 2018
6db1a7e
remove %>% usage
schloerke Oct 18, 2018
f0b3fc2
importFrom utils getFromNamespace
schloerke Oct 19, 2018
89a285b
make quizes work with shiny based questions
schloerke Oct 22, 2018
a6fbdcf
enforce question_is_correct_value return objects
schloerke Oct 22, 2018
0a490eb
return only the single question restore value when restoring a question
schloerke Oct 22, 2018
8b6d0d8
Join similar message types line break
schloerke Oct 22, 2018
436deb0
move finished todos with comments away from other todos
schloerke Oct 22, 2018
f41accd
first pass at passing r cmd check
schloerke Oct 22, 2018
8f57b26
first pass at removing slickQuiz
schloerke Oct 23, 2018
a2da361
update todos and fix s3 class value in question_stop
schloerke Oct 23, 2018
3f7ca86
document
schloerke Oct 23, 2018
7519e4f
add comment about localhost and devtools::load_all()
schloerke Nov 2, 2018
deea3d6
remove more of slickquiz and the question_submission http-handler
schloerke Nov 2, 2018
15ea7dc
reduce the set of ids supplied in a question
schloerke Nov 2, 2018
f854186
wrap a question answer container in a div to allow for styles to be a…
schloerke Nov 2, 2018
d7ab295
ignore tmp tutorials
schloerke Nov 2, 2018
ede9443
update js queries
schloerke Nov 6, 2018
dcbe8db
do not double record event
schloerke Nov 6, 2018
33ce968
remove question_submission init progress event and restore submission
schloerke Nov 6, 2018
8ded376
broadcast question event submission to client
schloerke Nov 6, 2018
4918913
match js css classes
schloerke Nov 6, 2018
b891728
tell the client when the app has loaded about the restoring answer
schloerke Nov 6, 2018
e2388d6
do not notify the client about quiz questions being correct. but do a…
schloerke Nov 6, 2018
b66d104
save question reset on server side
schloerke Nov 20, 2018
d9092da
make the question's shiny ui have a wrapping div for each question
schloerke Nov 20, 2018
38e1bdb
barret validate that chunk lables do not have unwanted characters to …
schloerke Nov 20, 2018
65238a8
have NS id be the chunk label
schloerke Nov 20, 2018
7e99ee8
more answers -> answer storage names
schloerke Nov 21, 2018
94ddb8c
fix str_trim to trim all white space on right side
schloerke Nov 21, 2018
d39297c
display a loading item until the question loads
schloerke Nov 21, 2018
11a1449
when a question is reset with try_again, remove all matching progress…
schloerke Nov 21, 2018
9e9910a
if knitr is not in progress, no need to verify the chunk name
schloerke Nov 21, 2018
294955d
pass R cmd check
schloerke Nov 21, 2018
4277b87
update notes
schloerke Nov 21, 2018
ab9fb5c
Merge pull request #1 from schloerke/no-save-correct
schloerke Nov 26, 2018
7d380c2
move answer -> answer officially. add comment for docs
schloerke Nov 26, 2018
ddc30dd
Merge branch 'master' into text_answer
schloerke Apr 4, 2019
32b8065
export methods to be found at execution time. ignore all tutorial .ht…
schloerke Apr 9, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Expand Up @@ -7,3 +7,5 @@
Untitled
issues

# atom config folder
.atom/
6 changes: 3 additions & 3 deletions R/initialize.R
Expand Up @@ -29,7 +29,7 @@ initialize_tutorial <- function() {
rmarkdown::shiny_prerendered_chunk(
'server',
sprintf('learnr:::register_http_handlers(session, metadata = %s)',
list_to_string(rmarkdown::metadata$tutorial)),
dput_to_string(rmarkdown::metadata$tutorial)),
singleton = TRUE
)

Expand All @@ -39,8 +39,8 @@ initialize_tutorial <- function() {
}


list_to_string <- function(x) {
conn <- textConnection("list_to_string", "w")
dput_to_string <- function(x) {
conn <- textConnection("dput_to_string", "w")
on.exit({close(conn)})
dput(x, file = conn)
paste0(textConnectionValue(conn), collapse = "")
Expand Down